From: "Paul E. McKenney" <paulmck@kernel.org>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH -perfbook 1/4] CodeSample/formal/rcutorture.sh: Ignore Makefile and Kconfig*
Date: Thu, 4 May 2023 17:46:40 -0700 [thread overview]
Message-ID: <3ebc2653-67b2-42b0-b280-8ee0d10a86d2@paulmck-laptop> (raw)
In-Reply-To: <0d6a6549-6292-d30b-c1a3-19b42f672480@gmail.com>
On Thu, May 04, 2023 at 08:41:03AM +0900, Akira Yokosawa wrote:
> kernel/rcu/Makefile was new to Linux v3.13 when RCU related code were
> moved under kernel/rcu/.
> kernel/rcu/Kconfig was new to Linux v4.13.
>
> Up until v3.12, RCU-related lines in Makefile and Kconfig were not
> counted. So, the extra counts result in a small disjoint of bar height,
> especially between v4.11 and v4.13.
> (v4.12 was an outlier due to code duplication of old and new SRCU.)
>
> Exclude those files from RCU LOC to be fair.
>
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
Looks good, queued and pushed, thank you!
Thanx, Paul
> ---
> CodeSamples/formal/rcutorture.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/CodeSamples/formal/rcutorture.sh b/CodeSamples/formal/rcutorture.sh
> index bc9a2855b623..236868054e47 100644
> --- a/CodeSamples/formal/rcutorture.sh
> +++ b/CodeSamples/formal/rcutorture.sh
> @@ -25,7 +25,7 @@ tags="`git tag -l | grep '^v' | grep -v -e - | grep -v '\..*\..*\.' | grep -v '2
> for t in $tags
> do
> git reset --hard $t > /dev/null 2>&1
> - nontorture="`ls kernel/*rcu*.* kernel/rcu/* include/linux/*rcu* 2> /dev/null | grep -v torture | grep -v rcuperf | grep -v refperf | grep -v rcuscale | grep -v refscale`"
> + nontorture="`ls kernel/*rcu*.* kernel/rcu/* include/linux/*rcu* 2> /dev/null | grep -v torture | grep -v rcuperf | grep -v refperf | grep -v rcuscale | grep -v refscale | grep -v Makefile | grep -v Kconfig`"
> ntn="`wc -l $nontorture 2> /dev/null | tail -1 | awk '{ print $1 }'`"
> tn="`wc -l tools/testing/selftests/rcutorture/configs/*/*.sh kernel/rcutorture.c kernel/rcu/torture.c kernel/rcu/rcutorture.c kernel/rcu/rcuperf.c kernel/rcu/refperf.c kernel/rcu/rcuscale.c kernel/rcu/refscale.c kernel/torture.c tools/testing/selftests/rcutorture/bin/* 2> /dev/null | tail -1 | awk '{ print $1 }'`"
> frac="`awk -v ntn=$ntn -v tn=$tn 'END { printf "%.1f", 100 * tn / (tn + ntn) "%"; }' < /dev/null`"
>
> base-commit: f8354eceed493a403160202591c6c383387c4ddc
> --
> 2.25.1
>
prev parent reply other threads:[~2023-05-05 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 23:41 [PATCH -perfbook 1/4] CodeSample/formal/rcutorture.sh: Ignore Makefile and Kconfig* Akira Yokosawa
2023-05-03 23:42 ` [PATCH -perfbook 2/4] Update rcu-test.dat as of v6.3, using updated rcutorture.sh Akira Yokosawa
2023-05-03 23:44 ` [PATCH -perfbook 3/4] CodeSamples/formal/data/plot.sh: Tweak plot params Akira Yokosawa
2023-05-03 23:45 ` [PATCH -perfbook 4/4] Update plot of RCU-test-ratio as of v6.3 Akira Yokosawa
2023-05-05 0:46 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ebc2653-67b2-42b0-b280-8ee0d10a86d2@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=akiyks@gmail.com \
--cc=perfbook@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).