From: "Leonardo Brás" <leobras.c@gmail.com>
To: paulmck@kernel.org, Akira Yokosawa <akiyks@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH] Add .gitlab-ci.yml for pdf generation and testing on Gitlab.
Date: Thu, 02 Feb 2023 23:19:52 -0300 [thread overview]
Message-ID: <39a31ffaa40176de5a2996c97e2b4d977d6c258f.camel@gmail.com> (raw)
In-Reply-To: <20230203000517.GB2948950@paulmck-ThinkPad-P17-Gen-1>
On Thu, 2023-02-02 at 16:05 -0800, Paul E. McKenney wrote:
> On Fri, Feb 03, 2023 at 08:51:04AM +0900, Akira Yokosawa wrote:
> > On Thu, 2 Feb 2023 15:31:27 -0800, Paul E. McKenney wrote:
> > > On Fri, Feb 03, 2023 at 08:23:05AM +0900, Akira Yokosawa wrote:
> > > > Hi,
> > > >
> > > > On Thu, 02 Feb 2023 13:52:08 -0300, Leonardo Brás wrote:
> > > > > On Thu, 2023-02-02 at 23:42 +0900, Akira Yokosawa wrote:
> > > > > > On Thu, 02 Feb 2023 01:37:02 -0300, Leonardo Brás wrote:
> > > > > > [...]
> > > > > > >
> > > > > > > It looks like it can be done by "Running CI/CD for external repositories".
> > > > >
> > > > > Nah, it looks like this won't work either. After my patch on top of master, it's
> > > > > already warning about diverging repositories when I try to sync.
> > > > >
> > > > > Another solution I could find:
> > > > > - Change the patch I sent before to keep the file on another directory, even
> > > > > with a different name: this will not trigger the build for anyone.
> > > > > - Change my repository config to trigger the CI from that file.
> > > > >
> > > > > The file would only be a random YML file in the repo.
> > > > > Would that be ok?
> > > >
> > > > Hmm, yes, I think I can live with it.
Great!
I created a patch for including the new yml file.
I created a new repo mirroring from the kernel.org repo, and created a new
branch with the above patch. Nothing happened on push.
Then I configured the correct yml file on Gitlab (details on the patch), and a
new push trigered the pipelines, so the desired effect was achieved.
> > > >
> > > > >
> > > > > > >
> > > > > > > I removed my previous repository and then imported perfbook again using the
> > > > > > > above mentioned mode. According to the man page, it will run CI for the project
> > > > > > > whenever a new push to the referenced repository happens.
> > > > > > >
> > > > > > > So it's just a matter of waiting a new commit getting push'ed to see if it will
> > > > > > > be working.
> > > > > >
> > > > > > Hi Leonardo,
> > > > > >
> > > > > > I noticed a minor glitch in the generated PDFs.
> > > > > > They don't have Git commit info in the title page and footer area of
> > > > > > pages.
> > > > > >
> > > > > > I can't tell what went wrong, but expected autodate.tex should look like:
> > > > >
> > > > > I found it out: gitlab was doing a shallow clone, and the previous tag was not
> > > > > in the commits, so I modified the Gitlab config so it does a complete clone of
> > > > > the repository instead.
> > > >
> > > > Aha! The script has never tested under a shallow clone...
> > > > Let me see if I can improve its behavior.
> > > >
> > > > > The last output of the pipeline seems to have been correct, please check:
> > > > > https://gitlab.com/linux-kernel/perfbook/-/jobs/3705185694/artifacts/browse
> > > >
> > > > Apparently, the commit id does not make sense in Paul's repo.
Yes, it was a commit in my personal tree.
> > > > But the random YML file approach should resolve it.
Agree.
> > >
> > > Apologies, I left it untracked. There is now a Leonardo.2023.02.01a
> > > branch that references it.
> >
> > I mean the commit id 81974e57 presented in the artifacts is of the commit
> > Leonardo made on his own:
> >
> > https://gitlab.com/linux-kernel/perfbook/-/commit/81974e57bed4
>
> You are right, that is not the Leonardo.2023.02.01a commit. Apologies
> for my confusion!
>
> Thanx, Paul
Please take a look in the new patch, it should sort everything out.
Best regards,
Leo
prev parent reply other threads:[~2023-02-03 2:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 20:15 [PATCH] Add .gitlab-ci.yml for pdf generation and testing on Gitlab Leonardo Bras
2023-02-01 22:13 ` Paul E. McKenney
2023-02-02 1:49 ` Akira Yokosawa
2023-02-02 1:53 ` Paul E. McKenney
2023-02-02 2:05 ` Leonardo Brás
2023-02-02 4:37 ` Leonardo Brás
2023-02-02 14:42 ` Akira Yokosawa
2023-02-02 16:52 ` Leonardo Brás
2023-02-02 23:23 ` Akira Yokosawa
2023-02-02 23:31 ` Paul E. McKenney
2023-02-02 23:51 ` Akira Yokosawa
2023-02-03 0:05 ` Paul E. McKenney
2023-02-03 2:19 ` Leonardo Brás [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39a31ffaa40176de5a2996c97e2b4d977d6c258f.camel@gmail.com \
--to=leobras.c@gmail.com \
--cc=akiyks@gmail.com \
--cc=paulmck@kernel.org \
--cc=perfbook@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).