From: "Paul E. McKenney" <paulmck@kernel.org>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: Leonardo Bras <leobras.c@gmail.com>, perfbook@vger.kernel.org
Subject: Re: [PATCH] utilities/gitlab-ci: Remove custom build of fig2ps
Date: Thu, 8 Jun 2023 11:21:05 -0700 [thread overview]
Message-ID: <26f066f9-a537-4c3b-b3b9-8566610a8ac4@paulmck-laptop> (raw)
In-Reply-To: <918699e4-d788-e891-5853-30d782631ff8@gmail.com>
On Tue, Jun 06, 2023 at 12:52:13PM +0900, Akira Yokosawa wrote:
> On Sat, 3 Jun 2023 14:55:37 -0300, Leonardo Bras wrote:
> > Since commit 1f907f3d77dd ("Use fig2dev as fallback to fig2eps"),
> > there is no need to install fig2ps in the container for building the pdfs.
> >
> > Remove those steps to simplify the building process.
> >
> > Suggested-by: Akira Yokosawa <akiyks@gmail.com>
> > Signed-off-by: Leonardo Bras <leobras.c@gmail.com>
> > ---
> >
> > Tested on Gitlab Pipeline:
> > https://gitlab.com/linux-kernel/perfbook/-/pipelines/888505608
>
> Reviewed-by: Akira Yokosawa <akiyks@gmail.com>
Queued and pushed, thank you both!
Thanx, Paul
> > utilities/gitlab-ci.yml | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/utilities/gitlab-ci.yml b/utilities/gitlab-ci.yml
> > index 6c3ec1e6..544b9373 100644
> > --- a/utilities/gitlab-ci.yml
> > +++ b/utilities/gitlab-ci.yml
> > @@ -21,9 +21,6 @@ generate_pdfs:
> > before_script:
> > - pacman --noconfirm -Sy texlive-meta fig2dev ghostscript graphviz inkscape wget make which fontconfig git ttf-dejavu gnu-free-fonts ttf-liberation
> > - mkdir -p ~/.local/share/fonts && cp fonts/steel-city-comic.regular.ttf ~/.local/share/fonts/ && fc-cache
> > - - wget https://sourceforge.net/projects/fig2ps/files/latest/download -O /dev/shm/fig2ps.tbz
> > - - mkdir /dev/shm/build && tar -xjf /dev/shm/fig2ps.tbz -C /dev/shm/build --strip-components=1
> > - - make install -C /dev/shm/build
> >
> > script:
> > - make perfbook.pdf perfbook-1c.pdf perfbook-eb.pdf
prev parent reply other threads:[~2023-06-08 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-03 17:55 [PATCH] utilities/gitlab-ci: Remove custom build of fig2ps Leonardo Bras
2023-06-06 3:52 ` Akira Yokosawa
2023-06-08 18:21 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26f066f9-a537-4c3b-b3b9-8566610a8ac4@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=akiyks@gmail.com \
--cc=leobras.c@gmail.com \
--cc=perfbook@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).