From: Alan Huang <mmpgouride@gmail.com>
To: paulmck@kernel.org, akiyks@gmail.com
Cc: perfbook@vger.kernel.org, Alan Huang <mmpgouride@gmail.com>
Subject: [PATCH v2] datastruct: Remove outdated content
Date: Tue, 9 May 2023 10:53:18 +0000 [thread overview]
Message-ID: <20230509105318.32998-1-mmpgouride@gmail.com> (raw)
The code of resizable hash table has been updated so that it doesn't
need to compute the hash twice since 2019. Here are some related
commits:
2ea492bbab9d ("datatruct/hash: Don't recompute hashes in hashtab_add()")
2a7f20d234e7 ("datastruct/hash: Don't recompute hashes in hashtab_del()")
...
So, the patch removes the outdated content.
Signed-off-by: Alan Huang <mmpgouride@gmail.com>
Reviewed-by: Akira Yokosawa <akiyks@gmail.com>
---
datastruct/datastruct.tex | 29 +++--------------------------
1 file changed, 3 insertions(+), 26 deletions(-)
diff --git a/datastruct/datastruct.tex b/datastruct/datastruct.tex
index 8c2bfc16..0242ccc7 100644
--- a/datastruct/datastruct.tex
+++ b/datastruct/datastruct.tex
@@ -2017,32 +2017,10 @@ which could allow the compiler to inline the resulting fixed functions,
eliminating not only the overhead of the call instruction, but the
argument marshalling as well.
-In addition, the resizable hash table is designed to fit an API
-that segregates bucket selection from concurrency control.
-Although this allows a single torture test to exercise all the hash-table
-implementations in this chapter, it also means that many operations
-must compute the hash and interact with possible resize operations twice
-rather than just once.
-In a performance-conscious environment, the \co{hashtab_lock_mod()}
-function would also return a reference to the bucket selected, eliminating
-the subsequent call to \co{ht_get_bucket()}.
-
-\QuickQuizSeries{%
-\QuickQuizB{
- Couldn't the \path{hashtorture.h} code be modified to accommodate
- a version of \co{hashtab_lock_mod()} that subsumes the
- \co{ht_get_bucket()} functionality?
-}\QuickQuizAnswerB{
- It probably could, and doing so would benefit all of the
- per-bucket-locked hash tables presented in this chapter.
- Making this modification is left as an exercise for the
- reader.
-}\QuickQuizEndB
-%
-\QuickQuizE{
+\QuickQuiz{
How much do these specializations really save?
Are they really worth it?
-}\QuickQuizAnswerE{
+}\QuickQuizAnswer{
The answer to the first question is left as an exercise to
the reader.
Try specializing the resizable hash table and see how much
@@ -2051,8 +2029,7 @@ the subsequent call to \co{ht_get_bucket()}.
instead be answered with respect to a specific use case.
Some use cases are extremely sensitive to performance and
scalability, while others are less so.
-}\QuickQuizEndE
-}
+}\QuickQuizEnd
All that aside, one of the great benefits of modern hardware compared
to that available when I first started learning to program back in
--
2.34.1
next reply other threads:[~2023-05-09 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 10:53 Alan Huang [this message]
2023-05-09 17:48 ` [PATCH v2] datastruct: Remove outdated content Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230509105318.32998-1-mmpgouride@gmail.com \
--to=mmpgouride@gmail.com \
--cc=akiyks@gmail.com \
--cc=paulmck@kernel.org \
--cc=perfbook@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).