perfbook.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj38.park@gmail.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: SeongJae Park <sj38.park@gmail.com>,
	paulmck@kernel.org, perfbook@vger.kernel.org, sj@kernel.org
Subject: Re: [PATCH v2 4/4] debugging/debugging: s/remainder of a section/following sections/
Date: Sun, 12 Feb 2023 08:49:17 -0800	[thread overview]
Message-ID: <20230212164917.25327-1-sj@kernel.org> (raw)
In-Reply-To: <655024e6-72fd-12bd-33f3-dc9700c42f44@gmail.com>

On Sun, 12 Feb 2023 21:29:40 +0900 Akira Yokosawa <akiyks@gmail.com> wrote:

> On Sat, 11 Feb 2023 09:10:08 -0800, SeongJae Park wrote:
> > A sectence in 'Microbenchmarking' section is mentioning the remainder of
> > the section will look at ways for dealing with conflicts in measurement
> > error advices.  Because we don't distinguish section and subsection on
> > text, this makes it a little confused, whether it means remainder of the
> > subsection, or the following subsections of the section.  Make it a bit
> > more clear.
> > 
> > Suggedsted-by: Paul E. McKenney <paulmck@kernel.org>
> > Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> > ---
> >  debugging/debugging.tex | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/debugging/debugging.tex b/debugging/debugging.tex
> > index b7538620..170bf273 100644
> > --- a/debugging/debugging.tex
> > +++ b/debugging/debugging.tex
> > @@ -641,8 +641,8 @@ sure to take full advantage of any existing test suites available to
> >  you.
> >  Important as test development is, we must leave further discussion of it
> >  to books dedicated to that topic.
> > -The following sections therefore discuss locating bugs in your code given that
> > -you already have a good test suite.
> > +The remainder of this section (\cref{sec:debugging:Performance Estimation})
> > +looks at ways of resolving this conflict.
> 
> I think this hunk is misplaced. Existing text around here doesn't
> have any ambiguity. In other words, "The following sections" means
> Sections 11.2 through 11.7 (11.8 is a summary). 

Oh, you're right.  I may need more coffee, sorry.

> 
> >  
> >  \section{Tracing}
> >  \label{sec:debugging:Tracing}
> > @@ -2302,7 +2302,7 @@ to creep in, including:
> >  
> >  The first and fourth sources of interference provide conflicting advice,
> >  which is one sign that we are living in the real world.
> > -The remainder of this section looks at ways of resolving this conflict.
> > +The following sections look at ways of resolving this conflict.
> 
> To my eyes, this sentence now looks redundant as there already is an
> introduction to the following subsections below QQz 11.23.

I agree.  I will simply remove this sentence in the next spin.


Thanks,
SJ

> 
> >  
> >  \QuickQuiz{
> >  	But what about other sources of error, for example, due to

      reply	other threads:[~2023-02-12 16:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-11 17:10 [PATCH v2 0/4] debugging: Trivial fixups SeongJae Park
2023-02-11 17:10 ` [PATCH v2 1/4] debugging: Use \co{} for 'time' output examples SeongJae Park
2023-02-12 12:02   ` Akira Yokosawa
2023-02-12 16:46     ` SeongJae Park
2023-02-11 17:10 ` [PATCH v2 2/4] debugging: Use \co{} and \qco{} for 'git' and 'Fixes:', respectively SeongJae Park
2023-02-11 17:10 ` [PATCH v2 3/4] debugging: Remove unnecessary space in a sentence SeongJae Park
2023-02-11 17:10 ` [PATCH v2 4/4] debugging/debugging: s/remainder of a section/following sections/ SeongJae Park
2023-02-12 12:29   ` Akira Yokosawa
2023-02-12 16:49     ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230212164917.25327-1-sj@kernel.org \
    --to=sj38.park@gmail.com \
    --cc=akiyks@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=perfbook@vger.kernel.org \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).