From: Dan Carpenter <dan.carpenter@linaro.org>
To: Karolina Stolarek <karolina.stolarek@intel.com>
Cc: Dorcas AnonoLitunya <anonolitunya@gmail.com>,
outreachy@lists.linux.dev, julia.lawall@inria.fr,
andi.shyti@linux.intel.com,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: sm750fb: Rename display_control_adjust_sm750LE
Date: Wed, 18 Oct 2023 12:31:18 +0300 [thread overview]
Message-ID: <d219a6b7-0b59-4894-a0c3-01e286f6a132@kadam.mountain> (raw)
In-Reply-To: <870b9b74-75bc-2a0d-7138-ae8df237f980@intel.com>
On Wed, Oct 18, 2023 at 10:12:19AM +0200, Karolina Stolarek wrote:
> On 18.10.2023 10:04, Dorcas AnonoLitunya wrote:
> > Rename function display_control_adjust_sm750LE to
> > display_control_adjust_sm750le. This further enforces snakecase naming
> > convention for consistent naming style throughout entire file.
> >
> > This change was suggested by Andi Shyti <andi.shyti@linux.intel.com>
>
> You can use Suggested-by tag here, if you wish (as per [1]) before
> Signed-off-by line.
Yeah
>
> In the first line of the commit, "Staging" should be lowercase.
There isn't really a rule on this. People do it either way. But, sure,
in this directory it's a 404 lower case vs 51 upper case so better to
follow the majority opinion.
In outreachy people are way more strict about some process issues than
we would be in real life. And that's fine, because it's an educational
process. I just worry that there is a certain amount of bleed over
where people start "correcting" people who haven't signed up to be in
outreachy.
regards,
dan carpenter
next prev parent reply other threads:[~2023-10-18 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 8:04 [PATCH v2] Staging: sm750fb: Rename display_control_adjust_sm750LE Dorcas AnonoLitunya
2023-10-18 8:12 ` Karolina Stolarek
2023-10-18 9:31 ` Dan Carpenter [this message]
2023-10-18 8:26 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d219a6b7-0b59-4894-a0c3-01e286f6a132@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=andi.shyti@linux.intel.com \
--cc=anonolitunya@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=karolina.stolarek@intel.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).