From: Julia Lawall <julia.lawall@inria.fr>
To: Dorine Tipo <dorine.a.tipo@gmail.com>
Cc: gagallo7+outreachy@gmail.com, outreachy@lists.linux.dev
Subject: Re: [PATCH] Fix Long Lines in lava-submit.sh
Date: Sun, 29 Oct 2023 08:39:46 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2310290835300.3136@hadrien> (raw)
In-Reply-To: <20231029063148.13081-1-dorine.a.tipo@gmail.com>
On Sun, 29 Oct 2023, Dorine Tipo wrote:
> This patch addresses an issue where line 38 in the 'lava-submit.sh' script exceeds 100 columns,
> which can make the code less readable. The problem is resolved by reformatting and breaking down
> the line to improve code readability and maintain compliance with coding style guidelines.
This log message is verbose. Please reread the Outreachy first patch
tutorial, particularly https://kernelnewbies.org/PatchPhilosophy
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> drivers/gpu/drm/ci/clean-lava-submit.sh | 58 +++++++++++++++++++++++++
> 1 file changed, 58 insertions(+)
> create mode 100755 drivers/gpu/drm/ci/clean-lava-submit.sh
>
> diff --git a/drivers/gpu/drm/ci/clean-lava-submit.sh b/drivers/gpu/drm/ci/clean-lava-submit.sh
> new file mode 100755
> index 000000000000..d4362f47fc14
> --- /dev/null
> +++ b/drivers/gpu/drm/ci/clean-lava-submit.sh
Why are you providing a completely new file? Please read the first patch
tutorial on how to create a patch from a changed file, particulary
starting from Committing your changes.
julia
> @@ -0,0 +1,58 @@
> +#!/bin/bash
> +# SPDX-License-Identifier: MIT
> +
> +set -e
> +set -x
> +
> +# Try to use the kernel and rootfs built in mainline first, so we're more
> +# likely to hit cache
> +if curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s "https://${BASE_SYSTEM_MAINLINE_HOST_PATH}/done"; then
> + BASE_SYSTEM_HOST_PATH="${BASE_SYSTEM_MAINLINE_HOST_PATH}"
> +else
> + BASE_SYSTEM_HOST_PATH="${BASE_SYSTEM_FORK_HOST_PATH}"
> +fi
> +
> +rm -rf results
> +mkdir -p results/job-rootfs-overlay/
> +
> +cp artifacts/ci-common/capture-devcoredump.sh results/job-rootfs-overlay/
> +cp artifacts/ci-common/init-*.sh results/job-rootfs-overlay/
> +cp artifacts/ci-common/intel-gpu-freq.sh results/job-rootfs-overlay/
> +cp "$SCRIPTS_DIR"/setup-test-env.sh results/job-rootfs-overlay/
> +
> +# Prepare env vars for upload.
> +section_start variables "Variables passed through:"
> +KERNEL_IMAGE_BASE="https://${BASE_SYSTEM_HOST_PATH}" \
> + artifacts/ci-common/generate-env.sh | tee results/job-rootfs-overlay/set-job-env-vars.sh
> +section_end variables
> +
> +tar zcf job-rootfs-overlay.tar.gz -C results/job-rootfs-overlay/ .
> +ci-fairy s3cp --token-file "${CI_JOB_JWT_FILE}" job-rootfs-overlay.tar.gz "https://${JOB_ROOTFS_OVERLAY_PATH}"
> +
> +touch results/lava.log
> +tail -f results/lava.log &
> +
> +PYTHONPATH=artifacts/ artifacts/lava/lava_job_submitter.py \
> + submit \
> + --dump-yaml \
> + --pipeline-info "$CI_JOB_NAME: $CI_PIPELINE_URL on
> + $CI_COMMIT_REF_NAME ${CI_NODE_INDEX}/${CI_NODE_TOTAL}" \
> + --rootfs-url-prefix "https://${BASE_SYSTEM_HOST_PATH}" \
> + --kernel-url-prefix "https://${PIPELINE_ARTIFACTS_BASE}/${DEBIAN_ARCH}" \
> + --build-url "${FDO_HTTP_CACHE_URI:-}https://${PIPELINE_ARTIFACTS_BASE}/${DEBIAN_ARCH}/kernel-files.tar.zst" \
> + --job-rootfs-overlay-url "${FDO_HTTP_CACHE_URI:-}https://${JOB_ROOTFS_OVERLAY_PATH}" \
> + --job-timeout-min ${JOB_TIMEOUT:-80} \
> + --first-stage-init artifacts/ci-common/init-stage1.sh \
> + --ci-project-dir "${CI_PROJECT_DIR}" \
> + --device-type "${DEVICE_TYPE}" \
> + --dtb-filename "${DTB}" \
> + --jwt-file "${CI_JOB_JWT_FILE}" \
> + --kernel-image-name "${KERNEL_IMAGE_NAME}" \
> + --kernel-image-type "${KERNEL_IMAGE_TYPE}" \
> + --boot-method "${BOOT_METHOD}" \
> + --visibility-group "${VISIBILITY_GROUP}" \
> + --lava-tags "${LAVA_TAGS}" \
> + --mesa-job-name "$CI_JOB_NAME" \
> + --structured-log-file "results/lava_job_detail.json" \
> + --ssh-client-image "${LAVA_SSH_CLIENT_IMAGE}" \
> + >> results/lava.log
> --
> 2.25.1
>
>
>
prev parent reply other threads:[~2023-10-29 7:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 6:31 [PATCH] Fix Long Lines in lava-submit.sh Dorine Tipo
2023-10-29 7:39 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2310290835300.3136@hadrien \
--to=julia.lawall@inria.fr \
--cc=dorine.a.tipo@gmail.com \
--cc=gagallo7+outreachy@gmail.com \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).