From: Alison Schofield <alison.schofield@intel.com>
To: Ayush Tiwari <ayushtiw0110@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: add const type to struct kobj_type gb_audio_module_type
Date: Wed, 13 Mar 2024 19:25:47 -0700 [thread overview]
Message-ID: <ZfJgK51wzy06WYdn@aschofie-mobl2> (raw)
In-Reply-To: <ZfH4YZ9qyK231T5l@ayush-HP-Pavilion-Gaming-Laptop-15-ec0xxx>
On Thu, Mar 14, 2024 at 12:32:57AM +0530, Ayush Tiwari wrote:
> Add type qualifier const in struct kobj_type gb_audio_module_type to
> address checkpatch warning and conform to the kernel coding style.
Thanks for the patch. A couple of things you could address in a v2:
1) 'Constify' is not a real English word, or maybe it's made its way
into an urban dictionary by now. Anyway, it's a common patch action
and you can read more about and improve the 'why' in your description.
Try: $ git log --pretty=oneline --abbrev-commit | grep Constify
and you'll find many patch examples. I think you'll find a crisper
'why' for your patch description.
Also, here's a former Outreachy Interns blog about the topic:
https://medium.com/@bhumikagoyal/linux-kernel-const-annotation-8db591148e58
2) Now that you know about the work 'Constify' please use it in your
commit message so that it doesn't cause line wrap (80 lines) when doing
$ git log --pretty=oneline --abbrev-commit audio_manager_module.c
See the First Patch Tutorial Section: Following the Driver commit style
Alison
>
> Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com>
> ---
> drivers/staging/greybus/audio_manager_module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
> index 5f9dcbdbc191..4a4dfb42f50f 100644
> --- a/drivers/staging/greybus/audio_manager_module.c
> +++ b/drivers/staging/greybus/audio_manager_module.c
> @@ -144,7 +144,7 @@ static struct attribute *gb_audio_module_default_attrs[] = {
> };
> ATTRIBUTE_GROUPS(gb_audio_module_default);
>
> -static struct kobj_type gb_audio_module_type = {
> +static const struct kobj_type gb_audio_module_type = {
> .sysfs_ops = &gb_audio_module_sysfs_ops,
> .release = gb_audio_module_release,
> .default_groups = gb_audio_module_default_groups,
> --
> 2.40.1
>
>
prev parent reply other threads:[~2024-03-14 2:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 19:02 [PATCH] staging: greybus: add const type to struct kobj_type gb_audio_module_type Ayush Tiwari
2024-03-14 2:25 ` Alison Schofield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfJgK51wzy06WYdn@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=Larry.Finger@lwfinger.net \
--cc=ayushtiw0110@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).