From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Dorine Tipo <dorine.a.tipo@gmail.com>,
Linux Outreachy <outreachy@lists.linux.dev>,
Greg KH <gregkh@linuxfoundation.org>,
Linux DRI Development <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Helen Koike <helen.koike@collabora.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Nick Terrell <terrelln@fb.com>,
Daniel Stone <daniels@collabora.com>,
Rob Clark <robdclark@gmail.com>
Subject: Re: [PATCH] Fix line Length
Date: Sun, 29 Oct 2023 21:11:07 +0700 [thread overview]
Message-ID: <ZT5n-5hSfD0MqsnT@debian.me> (raw)
In-Reply-To: <20231029135104.5136-1-dorine.a.tipo@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]
On Sun, Oct 29, 2023 at 01:51:04PM +0000, Dorine Tipo wrote:
>
> Fix the line lengths of lines 8 and 49
>
Is it checkpatch fix?
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> drivers/gpu/drm/ci/igt_runner.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ci/igt_runner.sh b/drivers/gpu/drm/ci/igt_runner.sh
> index 2bb759165063..d7b779bb7f64 100755
> --- a/drivers/gpu/drm/ci/igt_runner.sh
> +++ b/drivers/gpu/drm/ci/igt_runner.sh
> @@ -5,7 +5,8 @@ set -ex
>
> export IGT_FORCE_DRIVER=${DRIVER_NAME}
> export PATH=$PATH:/igt/bin/
> -export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu:/igt/lib:/igt/lib64
> +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib/aarch64-linux-gnu/:/igt/lib/x86_64-linux-gnu
> +export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/igt/lib:/igt/lib64
I'd like the former (single-line) assignment version.
> -curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /
> +curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s \
> + ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C /
This one LGTM.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-10-29 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 13:51 [PATCH] Fix line Length Dorine Tipo
2023-10-29 14:11 ` Bagas Sanjaya [this message]
2023-10-29 14:22 ` Julia Lawall
2023-10-30 6:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZT5n-5hSfD0MqsnT@debian.me \
--to=bagasdotme@gmail.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=daniels@collabora.com \
--cc=dorine.a.tipo@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=helen.koike@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy@lists.linux.dev \
--cc=robdclark@gmail.com \
--cc=terrelln@fb.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).