From: Felix Kimbu <felixkimbu1@gmail.com>
To: Alison Schofield <alison.schofield@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH v3] staging: wlan-ng: Rename 'foo' to 'rc' in p80211conv.c
Date: Wed, 13 Mar 2024 04:36:10 +0100 [thread overview]
Message-ID: <CAK=vLxJmefBNh9tseipYhQiYY6ZYZzoij3oCBKHy3qaH3+bGiw@mail.gmail.com> (raw)
In-Reply-To: <ZfC6JeVBa9weWBSU@aschofie-mobl2>
On Tue, Mar 12, 2024 at 9:25 PM Alison Schofield
<alison.schofield@intel.com> wrote:
Greetings Alison,
Thanks for the review. I will work and resubmit the v4 as guided.
Regards
>
> On Tue, Mar 12, 2024 at 06:11:53PM +0100, Felix N. Kimbu wrote:
>
> Hi Felix,
> Thanks for sending this v3 as a new patch. Now, I'm going to ask
> you to create a v4 to straighten out a bit more of the patch
> format.
>
> The commit message below includes some revision history that only
> belongs below the '---', Your commit message will be with this
> patch when it is committed, and the changelog will fall away.
> The changelog benefits reviewers today, and it also is always
> retrievable in Lore for folks curious about the patches journey.
>
> So, I'll make some edits directly below indicating what I think
> v4 should look like.
>
> Caveat 1: I didn't test the patch. I expect it applies, compiles,
> and passes checkpatch. Double check that all on v4.
>
> Caveat 2: I don't know if GregKH is going to accept this trivial
> patch. That's OK. By the time we get though v4 you will have
> applied a bunch of patching practices that you can take forward
> to your next patches.
>
> > Rename identifer 'foo' to 'rc' Suggested-by Alison Schofield in functions
> > skb_p80211_to_ether() and skb_ether_to_p80211().
> >
>
> Replace above with:
> Rename identifier 'foo' to 'rc' in skb_p80211_to_ether() and
> skb_ether_to_p80211() to match the common kernel coding style.
>
> (Try to get the spell checker running with checkpatch to catch things
> like the misspelled 'identifer' above.)
>
>
> Delete from here:
> > Fix indentation necessitated by above rename Suggested-by Dan Carpenter
> > and Philipp Hortmann.
> >
> > This change adds intuitive meaning to the idenfier, adhering to best
> > practices and coding style.
> >
> to here.
>
> >
> > Signed-off-by: Felix N. Kimbu <felixkimbu1@gmail.com>
> > ---
>
> (The names in parens is optional. Folks often do it to make
> it easier for reviewers to find what they last commented, and
> also it is a bit of a nod, appreciating your reviewers)
>
> Changes in v4:
> - Remove changelog comments from commit log (AlisonS)
>
> Changes in v3:
> - Create a proper new patch revision (AlisonS)
> - Use 'rc' instead of 'decrypt_check' (AlisonS)
>
> Changes in v2:
> - Fix wrong indentation introduced in v1 (DanC)
> - Correct subject to include driver (PhilippH)
>
>
prev parent reply other threads:[~2024-03-13 3:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 17:11 [PATCH v3] staging: wlan-ng: Rename 'foo' to 'rc' in p80211conv.c Felix N. Kimbu
2024-03-12 20:25 ` Alison Schofield
2024-03-13 3:36 ` Felix Kimbu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK=vLxJmefBNh9tseipYhQiYY6ZYZzoij3oCBKHy3qaH3+bGiw@mail.gmail.com' \
--to=felixkimbu1@gmail.com \
--cc=alison.schofield@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).