From: Dan Carpenter <dan.carpenter@linaro.org>
To: Calvince Otieno <calvncce@gmail.com>
Cc: gustavo@embeddedor.com, outreachy@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Martyn Welch <martyn@welchs.me.uk>,
Manohar Vanga <manohar.vanga@gmail.com>,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH V2] staging: vme_user: replace strcpy with strscpy
Date: Wed, 18 Oct 2023 13:22:06 +0300 [thread overview]
Message-ID: <8a1d6d6f-b650-4aad-9b31-07a0a8acf45c@kadam.mountain> (raw)
In-Reply-To: <ZS+c7NtfEw5ne2Oj@lab-ubuntu>
On Wed, Oct 18, 2023 at 11:53:00AM +0300, Calvince Otieno wrote:
> Checkpatch suggests using strscpy() instead of strcpy().
>
> The advantages of strscpy() are that it always adds a NUL terminator
> and prevents read overflows if the source string is not properly
> terminated.
strcpy() also always adds a NUL terminator.
With strcpy() both read overflows and write overflows are an issue but
write overflows are sooooooo much more serious that we don't worry about
read overflow.
> One potential disadvantage is that it doesn't zero pad the
> string like strcpy() does.
strcpy() does not zero pad anything. You're resending patches too
quickly. You should wait a day between resends.
>
> In this specific context, both strscpy and strcpy performs the same
> operation without any functional difference.
>
> The reason for this equivalence is that the driver_name string "vme_fake"
> is shorter than the size of the fake_bridge->name array which is defined
> as 16 characters (struct vme_bridge {char name[VMENAMSIZ];...}). Thus,
> there is no risk of buffer overflow in either case. VMENAMSIZ variable
> holds a constant value of 16 (#define VMENAMSIZ 16)
This paragraph is good and sufficient.
>
> The null-terminated "vme_fake" string
> (static const char driver_name[] = "vme_fake";) can be safely copied into
> fake_bridge->name using either strscpy or strcpy.
>
> While using strscpy() does not address any bugs, it is considered a better
> practice and aligns with checkpatch recommendations.
>
> Signed-off-by: Calvince Otieno <calvncce@gmail.com>
Okay. Good. Re-write the commit message and resend it tomorrow.
regards,
dan carpenter
prev parent reply other threads:[~2023-10-18 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 8:53 [PATCH V2] staging: vme_user: replace strcpy with strscpy Calvince Otieno
2023-10-18 10:22 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a1d6d6f-b650-4aad-9b31-07a0a8acf45c@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=calvncce@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).