From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Dorine Tipo <dorine.a.tipo@gmail.com>,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
outreachy@lists.linux.dev
Subject: Re: [PATCH v6] staging: vt6655: Match open parentheses
Date: Wed, 6 Mar 2024 06:40:04 +0100 [thread overview]
Message-ID: <66564bca-3f9a-4848-8453-c2ecd5f061ac@gmail.com> (raw)
In-Reply-To: <8add5a04-baab-49b8-b1b0-7b85131902f3@moroto.mountain>
On 3/6/24 05:59, Dan Carpenter wrote:
> On Tue, Mar 05, 2024 at 11:01:09PM +0100, Philipp Hortmann wrote:
>> On 3/5/24 10:32, Dorine Tipo wrote:
>>> Align the function parameters to silence a checkpatch warning.
>>>
>>> Signed-off-by: Dorine Tipo<dorine.a.tipo@gmail.com>
>>> ---
>>
>> Hi Dorine,
>> I tried to apply your patch but it failed. I do not really understand why.
>> Have you edited the patch manually or was it created by git?
>>
>> Thanks for your support.
>
> When you resend, could you start a new thread? We used to advise people
> to reply to the same thread but these days we always tell people to
> start a new thread for a new version.
>
> regards,
> dan carpenter
>
Hi Dorine,
one more thing would be nice. Could you make the Subject more unique?
Just think about the many patches the maintainer and reviewers have to
read and recognize for some time. Please add a filename or one of the
function names.
Thanks for your support.
Bye Philipp
prev parent reply other threads:[~2024-03-06 5:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240304142603.32982-2-dorine.a.tipo@gmail.com>
2024-03-05 9:14 ` [PATCH v5] staging: vt6655: Match open parentheses Dorine Tipo
2024-03-05 9:32 ` [PATCH v6] " Dorine Tipo
2024-03-05 22:01 ` Philipp Hortmann
2024-03-06 4:59 ` Dan Carpenter
2024-03-06 5:40 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66564bca-3f9a-4848-8453-c2ecd5f061ac@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=dorine.a.tipo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).