From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Calvince Otieno <calvncce@gmail.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Luke Koch <lu.ale.koch@gmail.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Simon Horman <horms@kernel.org>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: wlan-ng: remove unused functions
Date: Sun, 15 Oct 2023 11:24:43 +0200 [thread overview]
Message-ID: <5dd59334-428b-4e27-8d19-7b8514bb5ef5@t-8ch.de> (raw)
In-Reply-To: <CADFX3OSqnjGrxRazmmcBuGUOyv4TuXGEJ8fqbAhR4X9j0rn6sA@mail.gmail.com>
Hi Calvince,
On 2023-10-15 10:39:20+0300, Calvince Otieno wrote:
> On Sun, Oct 15, 2023 at 10:38 AM Calvince Otieno <calvncce@gmail.com> wrote:
> > On Fri, Oct 13, 2023 at 12:02 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
> >
> > On Fri, Oct 13, 2023 at 09:52:50AM +0300, Calvince Otieno wrote:
> > > The following functions were defined in the prism2mgmt.h file but neither
> > > declared nor used anywhere. It is recommended that they be removed.
> > >
> > > - void prism2mgmt_get_grpaddr(u32 did, struct p80211pstrd *pstr,
> > > struct hfa384x *priv);
> > > - int prism2mgmt_set_grpaddr(u32 did,
> > > u8 *prism2buf, struct p80211pstrd *pstr,
> > > struct hfa384x *priv);
> > > - int prism2mgmt_get_grpaddr_index(u32 did);
> > >
> >
> > Could you look up when the functions were deleted and add that
> > information to the commit message?
> >
> > These functions were removed five years ago in commit 123412341234
> > ("delete functions").
> >
> > regards,
> > dan carpenter
>
> I am not able to locate exactly when these functions were deleted.
> I have checked the commit history of these files prism2mgmt.h and prism2mgmt.c,
> but, I can't find any commit relating to the removal of the above functions.
you can use the "-S" argument to "git log" for this quite nicely:
$ git log --pretty=oneline -Sprism2mgmt_set_grpaddr drivers/staging/wlan-ng
1e7201836c576883d5bd708810cc72ab1392756f Staging: wlan-ng: Delete a pile of unused mibs. And fix WEXT SET_TXPOWER.
cbec30c4c00c9f5a7357f5c5dacb63ae2378afb4 Staging: wlan-ng: Delete a large pile of now-unused code.
00b3ed1685089ff52169a715de11106ed37df087 Staging: add wlan-ng prism2 usb driver
This shows all the commits that touched the drivers/staging/wlan-ng
directory and added or removed the string "prism2mgmt_set_grpadd".
You can check which of these three commits dropped the function and then
repeat the procedure for the other two functions.
Thomas
prev parent reply other threads:[~2023-10-15 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 6:52 [PATCH] staging: wlan-ng: remove unused functions Calvince Otieno
2023-10-13 9:02 ` Dan Carpenter
2023-10-15 7:39 ` Calvince Otieno
2023-10-15 9:24 ` Thomas Weißschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dd59334-428b-4e27-8d19-7b8514bb5ef5@t-8ch.de \
--to=linux@weissschuh.net \
--cc=bagasdotme@gmail.com \
--cc=calvncce@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lu.ale.koch@gmail.com \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).