From: Dan Carpenter <dan.carpenter@linaro.org>
To: Gilbert Adikankwu <gilbertadikankwu@gmail.com>
Cc: gregkh@linuxfoundation.org, outreachy@lists.linux.dev,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: Align descendant arguments
Date: Mon, 16 Oct 2023 08:39:16 +0300 [thread overview]
Message-ID: <3620a5eb-34d8-49ae-a925-66f85a62e09c@kadam.mountain> (raw)
In-Reply-To: <ZSuYUmX5P5M0Ok/I@gilbert-PC>
On Sun, Oct 15, 2023 at 08:44:18AM +0100, Gilbert Adikankwu wrote:
> diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c
> index 54747fda552f..a81e88894e01 100644
> --- a/drivers/staging/rtl8192u/r8190_rtl8256.c
> +++ b/drivers/staging/rtl8192u/r8190_rtl8256.c
> @@ -46,17 +46,17 @@ void phy_set_rf8256_bandwidth(struct net_device *dev, enum ht_channel_width Band
> priv->card_8192_version == VERSION_819XU_B) {
> /* 8256 D-cut, E-cut, xiong: consider it later! */
> rtl8192_phy_SetRFReg(dev,
> - (enum rf90_radio_path_e)eRFPath,
> - 0x0b, bMask12Bits, 0x100); /* phy para:1ba */
> + (enum rf90_radio_path_e)eRFPath,
> + 0x0b, bMask12Bits, 0x100); /* phy para:1ba */
These ones go too long indented like this. The other sections are fine
but just leave leave this file as it was.
regards,
dan carpenter
> rtl8192_phy_SetRFReg(dev,
> - (enum rf90_radio_path_e)eRFPath,
> - 0x2c, bMask12Bits, 0x3d7);
> + (enum rf90_radio_path_e)eRFPath,
> + 0x2c, bMask12Bits, 0x3d7);
> rtl8192_phy_SetRFReg(dev,
> - (enum rf90_radio_path_e)eRFPath,
> - 0x0e, bMask12Bits, 0x021);
> + (enum rf90_radio_path_e)eRFPath,
> + 0x0e, bMask12Bits, 0x021);
> rtl8192_phy_SetRFReg(dev,
> - (enum rf90_radio_path_e)eRFPath,
> - 0x14, bMask12Bits, 0x5ab);
> + (enum rf90_radio_path_e)eRFPath,
> + 0x14, bMask12Bits, 0x5ab);
> } else {
> RT_TRACE(COMP_ERR, "%s(): unknown hardware version\n", __func__);
> }
prev parent reply other threads:[~2023-10-16 5:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 7:44 [PATCH] staging: rtl8192u: Align descendant arguments Gilbert Adikankwu
2023-10-15 8:24 ` Andi Shyti
2023-10-15 8:35 ` Gilbert Adikankwu
2023-10-15 8:39 ` Andi Shyti
2023-10-15 16:09 ` Greg KH
2023-10-16 5:39 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3620a5eb-34d8-49ae-a925-66f85a62e09c@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=gilbertadikankwu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).