From: Julia Lawall <julia.lawall@inria.fr>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Calvince Otieno <calvncce@gmail.com>,
outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Luke Koch <lu.ale.koch@gmail.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Simon Horman <horms@kernel.org>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v4] staging: wlan-ng: replace strncpy() with strscpy()
Date: Fri, 13 Oct 2023 12:16:41 +0200 (CEST) [thread overview]
Message-ID: <2a603886-332c-9b2b-45fa-3dea8f4162f@inria.fr> (raw)
In-Reply-To: <b53cc9c0-f1fd-43ae-85d9-2c502fc4fcec@kadam.mountain>
On Fri, 13 Oct 2023, Dan Carpenter wrote:
> On Fri, Oct 13, 2023 at 12:54:26PM +0300, Calvince Otieno wrote:
> > Checkpatch suggests the use of strscpy() instead of strncpy().
Since Dan suggested another change, you could also drop the extra space
before strscpy in the line above.
julia
> > The advantages are that it always adds a NUL terminator and it prevents
> > a read overflow if the src string is not properly terminated. One
> > potential disadvantage is that it doesn't zero pad the string like
> > strncpy() does.
> >
> > In this code, strscpy() and strncpy() are equivalent and it does not
> > affect runtime behavior. The string is zeroed on the line before
> > using memset(). The resulting string was always NUL terminated and
> > PRISM2_USB_FWFILE is string literal "prism2_ru.fw" so it's NUL
> > terminated.
> >
> > However, even though using strscpy() does not fix any bugs, it's
> > still nicer and makes checkpatch happy.
> >
> > Signed-off-by: Calvince Otieno <calvncce@gmail.com>
> > ---
> > Patch version v4:
> > Provide a valid description of the patch
>
> Good.
>
> However, you've still included the v1 patch... See below. Don't do
> that.
>
> regards,
> dan carpenter
>
> > Patch version v1:
> > Replacing strncpy() with strscpy()
> >
> > drivers/staging/wlan-ng/prism2fw.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
> > index 5d03b2b9aab4..57a99dd12143 100644
> > --- a/drivers/staging/wlan-ng/prism2fw.c
> > +++ b/drivers/staging/wlan-ng/prism2fw.c
> > @@ -725,7 +725,7 @@ static int plugimage(struct imgchunk *fchunk, unsigned int nfchunks,
> >
> > if (j == -1) { /* plug the filename */
> > memset(dest, 0, s3plug[i].len);
> > - strncpy(dest, PRISM2_USB_FWFILE, s3plug[i].len - 1);
> > + strscpy(dest, PRISM2_USB_FWFILE, s3plug[i].len - 1);
> > } else { /* plug a PDR */
> > memcpy(dest, &pda->rec[j]->data, s3plug[i].len);
> > }
> >
> > --
> > Calvince Otieno
> >
>
>
prev parent reply other threads:[~2023-10-13 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 9:54 [PATCH v4] staging: wlan-ng: replace strncpy() with strscpy() Calvince Otieno
2023-10-13 9:59 ` Dan Carpenter
2023-10-13 10:16 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a603886-332c-9b2b-45fa-3dea8f4162f@inria.fr \
--to=julia.lawall@inria.fr \
--cc=bagasdotme@gmail.com \
--cc=calvncce@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lu.ale.koch@gmail.com \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).