From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dorine Tipo <dorine.a.tipo@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
outreachy@lists.linux.dev
Subject: Re: [PATCH v5] Staging: octeon: Match parenthesis alignment
Date: Tue, 5 Mar 2024 12:41:43 +0300 [thread overview]
Message-ID: <20d2859c-07c6-466f-a48d-4c96b414e25f@moroto.mountain> (raw)
In-Reply-To: <20240305092310.3594-1-dorine.a.tipo@gmail.com>
On Tue, Mar 05, 2024 at 09:23:10AM +0000, Dorine Tipo wrote:
> Align the function parameters to silence a checkpatch warning.
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> Changelog:
>
> V2: Fixed the warnings in the patch as suggested by
> <philipp.g.hortmann@gmail.com>
>
> V3: Reworked this patch as a separate patchset as suggested by
> <dan.carpenter@linaro.org>
>
> V4: Added a changelog at the bottom as suggested by
> <gregkh@linuxfoundation.org>
>
> V5: Fixed the commit message
The v4 commit message was fine. I was reviewing the v3 commit message
which was messed up and proposed a sample commit message. But yours
was also fine.
regards,
dan carpenter
prev parent reply other threads:[~2024-03-05 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2024030422-backstage-derby-a1e4@gregkh>
2024-03-05 5:14 ` [PATCH v4] Staging: octeon: Match parenthesis alignment Dorine Tipo
2024-03-05 9:23 ` [PATCH v5] " Dorine Tipo
2024-03-05 9:41 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20d2859c-07c6-466f-a48d-4c96b414e25f@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=dorine.a.tipo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).