From: Greg KH <gregkh@linuxfoundation.org>
To: Dorine Tipo <dorine.a.tipo@gmail.com>
Cc: linux-staging@lists.linux.dev, outreachy@lists.linux.dev
Subject: Re: [PATCH] Staging:sm750fb: Rename variable sii164GetChipString
Date: Thu, 7 Mar 2024 07:22:09 +0000 [thread overview]
Message-ID: <2024030750-sneak-unpack-c7e1@gregkh> (raw)
In-Reply-To: <2024030721-mammogram-exquisite-69e9@gregkh>
On Thu, Mar 07, 2024 at 07:21:33AM +0000, Greg KH wrote:
> On Tue, Mar 05, 2024 at 10:32:48PM +0000, Dorine Tipo wrote:
> > Rename variable sii164GetChipString to sii164Get_chip_string to fix
> > checkpatch warning Avoid CamelCase
>
> That's not what this patch does :(
>
Also, did you test-build it? Your change looks to break the build,
sorry.
greg k-h
prev parent reply other threads:[~2024-03-07 7:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 22:32 [PATCH] Staging:sm750fb: Rename variable sii164GetChipString Dorine Tipo
2024-03-07 7:21 ` Greg KH
2024-03-07 7:22 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024030750-sneak-unpack-c7e1@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dorine.a.tipo@gmail.com \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).