outreachy.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Dorcas AnonoLitunya <anonolitunya@gmail.com>
Cc: anonolitunya@gmail.com, outreachy@lists.linux.dev,
	julia.lawall@inria.fr, dan.carpenter@linaro.org,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Teddy Wang <teddy.wang@siliconmotion.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] staging: sm750fb: Remove unused return values from functions
Date: Thu, 19 Oct 2023 13:13:35 +0300	[thread overview]
Message-ID: <20231019101348.22076-1-anonolitunya@gmail.com> (raw)

Modifies the return type of different static functions to void and
deletes unused return variables as the return value is being ignored 
in all subsequent function calls thus not useful to have a return type.

This improves code readability and maintainability.

Changes in v2:
- Ammend wording in cover letter.
Suggested-by: Julia Lawall <julia.lawall@inria.fr>
- Drop variable 'ret' entirely as it is unused.
Suggested-by: Julia Lawall <julia.lawall@inria.fr>, Greg Kroah-Hartman
<gregkh@linuxfoundation.org>, Dan Carpenter <dan.carpenter@linaro.org> 

Dorcas AnonoLitunya (2):
  staging: sm750fb: Remove unused return value in
    display_control_adjust_sm750le()
  staging: sm750fb: Remove unused return variable in
    program_mode_registers()

 drivers/staging/sm750fb/ddk750_mode.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

-- 
2.42.0.345.gaab89be2eb


             reply	other threads:[~2023-10-19 10:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19 10:13 Dorcas AnonoLitunya [this message]
2023-10-19 10:13 ` [PATCH v2 1/2] staging: sm750fb: Remove unused return value in display_control_adjust_sm750le() Dorcas AnonoLitunya
2023-10-21 10:01   ` Greg Kroah-Hartman
2023-11-01 15:36     ` Dorcas Anono Litunya
2023-10-19 10:13 ` [PATCH v2 2/2] staging: sm750fb: Remove unused return variable in program_mode_registers() Dorcas AnonoLitunya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231019101348.22076-1-anonolitunya@gmail.com \
    --to=anonolitunya@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=julia.lawall@inria.fr \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).