From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH] or1k: Define PI_STATIC_AND_HIDDEN
Date: Mon, 21 Feb 2022 15:07:30 -0300 [thread overview]
Message-ID: <df791ab9-d0e6-090d-6164-817b4e8574db@linaro.org> (raw)
In-Reply-To: <20220128232842.3329969-1-shorne@gmail.com>
On 28/01/2022 20:28, Stafford Horne wrote:
> PI_STATIC_AND_HIDDEN means that references to static functions, data
> and symbols with hidden visibility do not need any run-time relocations
> after the final link, with the build flags used by glibc.
>
> OpenRISC follows this so enabled PI_STATIC_AND_HIDDEN by adding
> configure.ac and generating configure.
>
> Suggested-by: Florian Weimer <fweimer@redhat.com>
LGTM, thanks. Stafford, you are the or1k maintainer and most likely the
one with a setup to actually test it. For such arch specific changes,
you can push it without require other maintainer ack.
> ---
> This was discussed on the mailing list:
> https://sourceware.org/pipermail/libc-alpha/2022-January/135620.html
>
> I thought to get this out as I start to test 2.35 we want this change in.
>
> sysdeps/or1k/configure | 5 +++++
> sysdeps/or1k/configure.ac | 4 ++++
> 2 files changed, 9 insertions(+)
> create mode 100644 sysdeps/or1k/configure
> create mode 100644 sysdeps/or1k/configure.ac
>
> diff --git a/sysdeps/or1k/configure b/sysdeps/or1k/configure
> new file mode 100644
> index 0000000000..d73db4ddbe
> --- /dev/null
> +++ b/sysdeps/or1k/configure
> @@ -0,0 +1,5 @@
> +# This file is generated from configure.ac by Autoconf. DO NOT EDIT!
> + # Local configure fragment for sysdeps/or1k/elf.
> +
> +$as_echo "#define PI_STATIC_AND_HIDDEN 1" >>confdefs.h
> +
> diff --git a/sysdeps/or1k/configure.ac b/sysdeps/or1k/configure.ac
> new file mode 100644
> index 0000000000..db6a6087e1
> --- /dev/null
> +++ b/sysdeps/or1k/configure.ac
> @@ -0,0 +1,4 @@
> +GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory.
> +# Local configure fragment for sysdeps/or1k/elf.
> +
> +AC_DEFINE(PI_STATIC_AND_HIDDEN)
prev parent reply other threads:[~2022-02-21 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 23:28 [OpenRISC] [PATCH] or1k: Define PI_STATIC_AND_HIDDEN Stafford Horne
2022-02-21 18:07 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df791ab9-d0e6-090d-6164-817b4e8574db@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=openrisc@lists.librecores.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).