From: Stafford Horne <shorne@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jonas Bonn <jonas@southpole.se>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
openrisc@lists.librecores.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] openrisc: update config files
Date: Thu, 29 Sep 2022 16:27:06 +0000 [thread overview]
Message-ID: <YzXHWteIFh2kUOXY@oscomms1> (raw)
In-Reply-To: <CAMuHMdWx5RKP8WfNAyOofGFTGQNfOtDYMOJmvPgPhtyvRPG1Bw@mail.gmail.com>
Hi Geert,
On Thu, Sep 29, 2022 at 05:07:40PM +0200, Geert Uytterhoeven wrote:
> Hi Stafford,
>
> On Thu, Sep 29, 2022 at 4:30 PM Stafford Horne <shorne@gmail.com> wrote:
> > On Thu, Sep 29, 2022 at 02:21:46PM +0000, Stafford Horne wrote:
> > > On Thu, Sep 29, 2022 at 12:14:58PM +0200, Lukas Bulwahn wrote:
> > > > Clean up config files by:
> > > > - removing configs that were deleted in the past
> > > > - removing configs not in tree and without recently pending patches
> > > > - adding new configs that are replacements for old configs in the file
>
> > > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > >
> > > Thanks for the patch this looks fine to me. Usually I just generate this
> > > defcnfigs using make savedefconfig. If there is some better way which
> > > doesn't generate the file with the # comment's I haven't found it.
> > >
> > > I will queue this.
> >
> > Actually..
> >
> > About the subject 'openrisc: update config files' and description. Can you be
> > more specific about what updates you are making for this patch?
> >
> > For example: remove comments from config files.
>
> These are not comments, but options that default to y or m, and
> are overriden to n by "commenting them out".
>
> This syntax dates back to the days Kconfig was a collection of
> shell scripts. Nowadays, switching to "CONFIG_<FOO>=n" would
> perhaps make sense, as Kconfig already recognizes that syntax.
Right, I remember the *comment's* do actually are material to the config files.
In this patch not everything is removed, just old non-existent configs.
I sill prefer having a more descriptive subject.
-Stafford
> > > > --- a/arch/openrisc/configs/or1ksim_defconfig
> > > > +++ b/arch/openrisc/configs/or1ksim_defconfig
> > > > @@ -19,9 +19,6 @@ CONFIG_NET=y
> > > > CONFIG_PACKET=y
> > > > CONFIG_UNIX=y
> > > > CONFIG_INET=y
> > > > -# CONFIG_INET_XFRM_MODE_TRANSPORT is not set
> > > > -# CONFIG_INET_XFRM_MODE_TUNNEL is not set
> > > > -# CONFIG_INET_XFRM_MODE_BEET is not set
> > > > # CONFIG_INET_DIAG is not set
> > > > CONFIG_TCP_CONG_ADVANCED=y
> > > > # CONFIG_TCP_CONG_BIC is not set
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
prev parent reply other threads:[~2022-09-29 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 10:14 [PATCH] openrisc: update config files Lukas Bulwahn
2022-09-29 14:21 ` Stafford Horne
2022-09-29 14:30 ` Stafford Horne
2022-09-29 15:07 ` Geert Uytterhoeven
2022-09-29 16:27 ` Stafford Horne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzXHWteIFh2kUOXY@oscomms1 \
--to=shorne@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jonas@southpole.se \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=openrisc@lists.librecores.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).