From: Samuel Holland <samuel@sholland.org>
To: Stafford Horne <shorne@gmail.com>
Cc: openrisc@lists.librecores.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] or1k: Add support for a little-endian target variant
Date: Thu, 9 Jun 2022 21:07:25 -0500 [thread overview]
Message-ID: <424f88ac-49de-0804-f2b6-4b788ae8ef80@sholland.org> (raw)
In-Reply-To: <YqHZnGBh6ty6MiJp@antec>
Hi Stafford,
On 6/9/22 6:29 AM, Stafford Horne wrote:
>> diff --git a/gcc/config.gcc b/gcc/config.gcc
>> index c5064dd37666..0c3a09dfe810 100644
>> --- a/gcc/config.gcc
>> +++ b/gcc/config.gcc
>> @@ -2866,6 +2866,11 @@ or1k*-*-*)
>> done
>> TM_MULTILIB_CONFIG=`echo $TM_MULTILIB_CONFIG | sed 's/^,//'`
>>
>> + case ${target} in
>> + or1k*le*-*)
>
> Should this be just or1kle*-*?
I wasn't sure what the order of "le" and "nd" would be if both were present.
>> + tm_defines="${tm_defines} TARGET_LITTLE_ENDIAN_DEFAULT=1"
>> + ;;
>> + esac
>> case ${target} in
>> or1k*-*-linux*)
>> tm_file="${tm_file} gnu-user.h linux.h glibc-stdint.h"
>
>
>> diff --git a/gcc/config/or1k/or1k.opt b/gcc/config/or1k/or1k.opt
>> index 8a66832a99b1..497f259faae9 100644
>> --- a/gcc/config/or1k/or1k.opt
>> +++ b/gcc/config/or1k/or1k.opt
>> @@ -24,6 +24,14 @@
>> HeaderInclude
>> config/or1k/or1k-opts.h
>>
>> +mbig-endian
>> +Target Report RejectNegative Mask(BIG_ENDIAN)
>> +Use big-endian byte order.
>> +
>> +mlittle-endian
>> +Target Report RejectNegative InverseMask(BIG_ENDIAN, LITTLE_ENDIAN)
>> +Use little-endian byte order.
>> +
>
> We should explain what is the default int he doc's.
>
> Can you also document in: gcc/doc/invoke.texi
Yes, I will do that for v2.
Regards,
Samuel
next prev parent reply other threads:[~2022-06-10 2:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 6:03 [PATCH] or1k: Add support for a little-endian target variant Samuel Holland
2022-06-09 11:29 ` Stafford Horne
2022-06-10 2:07 ` Samuel Holland [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-06-09 6:01 Samuel Holland
2022-06-09 11:21 ` Stafford Horne
2022-06-10 1:00 ` Alan Modra
2022-06-10 1:39 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=424f88ac-49de-0804-f2b6-4b788ae8ef80@sholland.org \
--to=samuel@sholland.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=openrisc@lists.librecores.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).