From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: "wuqiang.matt" <wuqiang.matt@bytedance.com>
Cc: vgupta@kernel.org, bcain@quicinc.com, jonas@southpole.se,
stefan.kristiansson@saunalahti.fi, shorne@gmail.com,
geert@linux-m68k.org, andi.shyti@linux.intel.com,
mingo@kernel.org, palmer@rivosinc.com, andrzej.hajda@intel.com,
arnd@arndb.de, peterz@infradead.orgm,
linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, mattwu@163.com,
linux@roeck-us.ne, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 4/4] locking/atomic: hexagon: arch_cmpxchg[64]_local undefined
Date: Wed, 8 Nov 2023 10:04:47 +0900 [thread overview]
Message-ID: <20231108100447.8bd6ff06f59f4b41a8f3d0ec@kernel.org> (raw)
In-Reply-To: <20231104091615.4884-5-wuqiang.matt@bytedance.com>
On Sat, 4 Nov 2023 17:16:15 +0800
"wuqiang.matt" <wuqiang.matt@bytedance.com> wrote:
> For architectures that support native cmpxchg, we'd like to
> implement arch_cmpxchg[64]_local with the native variants of
> supported data size. If not, the generci_cmpxchg[64]_local
> will be used.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310272207.tLPflya4-lkp@intel.com/
>
Looks good to me.
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
But I need hexagon's maintainer's comment too.
Thank you,
> Signed-off-by: wuqiang.matt <wuqiang.matt@bytedance.com>
> ---
> arch/hexagon/include/asm/cmpxchg.h | 51 +++++++++++++++++++++++++++++-
> 1 file changed, 50 insertions(+), 1 deletion(-)
>
> diff --git a/arch/hexagon/include/asm/cmpxchg.h b/arch/hexagon/include/asm/cmpxchg.h
> index bf6cf5579cf4..2b5e5bbaf807 100644
> --- a/arch/hexagon/include/asm/cmpxchg.h
> +++ b/arch/hexagon/include/asm/cmpxchg.h
> @@ -8,6 +8,8 @@
> #ifndef _ASM_CMPXCHG_H
> #define _ASM_CMPXCHG_H
>
> +#include <linux/build_bug.h>
> +
> /*
> * __arch_xchg - atomically exchange a register and a memory location
> * @x: value to swap
> @@ -51,13 +53,15 @@ __arch_xchg(unsigned long x, volatile void *ptr, int size)
> * variable casting.
> */
>
> -#define arch_cmpxchg(ptr, old, new) \
> +#define __cmpxchg_32(ptr, old, new) \
> ({ \
> __typeof__(ptr) __ptr = (ptr); \
> __typeof__(*(ptr)) __old = (old); \
> __typeof__(*(ptr)) __new = (new); \
> __typeof__(*(ptr)) __oldval = 0; \
> \
> + BUILD_BUG_ON(sizeof(*(ptr)) != 4); \
> + \
> asm volatile( \
> "1: %0 = memw_locked(%1);\n" \
> " { P0 = cmp.eq(%0,%2);\n" \
> @@ -72,4 +76,49 @@ __arch_xchg(unsigned long x, volatile void *ptr, int size)
> __oldval; \
> })
>
> +#define __cmpxchg(ptr, old, val, size) \
> +({ \
> + __typeof__(*(ptr)) oldval; \
> + \
> + switch (size) { \
> + case 4: \
> + oldval = __cmpxchg_32(ptr, old, val); \
> + break; \
> + default: \
> + BUILD_BUG(); \
> + oldval = val; \
> + break; \
> + } \
> + \
> + oldval; \
> +})
> +
> +#define arch_cmpxchg(ptr, o, n) __cmpxchg((ptr), (o), (n), sizeof(*(ptr)))
> +
> +/*
> + * always make arch_cmpxchg[64]_local available, native cmpxchg
> + * will be used if available, then generic_cmpxchg[64]_local
> + */
> +#include <asm-generic/cmpxchg-local.h>
> +
> +#define arch_cmpxchg_local(ptr, old, val) \
> +({ \
> + __typeof__(*(ptr)) retval; \
> + int size = sizeof(*(ptr)); \
> + \
> + switch (size) { \
> + case 4: \
> + retval = __cmpxchg_32(ptr, old, val); \
> + break; \
> + default: \
> + retval = __generic_cmpxchg_local(ptr, old, \
> + val, size); \
> + break; \
> + } \
> + \
> + retval; \
> +})
> +
> +#define arch_cmpxchg64_local(ptr, o, n) __generic_cmpxchg64_local((ptr), (o), (n))
> +
> #endif /* _ASM_CMPXCHG_H */
> --
> 2.40.1
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
prev parent reply other threads:[~2023-11-08 1:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 9:16 [PATCH v2 0/4] locking/atomic: arch_cmpxchg[64]_local undefined wuqiang.matt
2023-11-04 9:16 ` [PATCH v2 1/4] locking/atomic: arc: data size checking in arch_cmpxchg wuqiang.matt
2023-11-08 1:02 ` Masami Hiramatsu
2023-11-04 9:16 ` [PATCH v2 2/4] locking/atomic: arc: arch_cmpxchg[64]_local undefined wuqiang.matt
2023-11-08 1:02 ` Masami Hiramatsu
2023-11-04 9:16 ` [PATCH v2 3/4] locking/atomic: openrisc: " wuqiang.matt
2023-11-08 1:03 ` Masami Hiramatsu
2023-11-04 9:16 ` [PATCH v2 4/4] locking/atomic: hexagon: " wuqiang.matt
2023-11-08 1:04 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231108100447.8bd6ff06f59f4b41a8f3d0ec@kernel.org \
--to=mhiramat@kernel.org \
--cc=andi.shyti@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=arnd@arndb.de \
--cc=bcain@quicinc.com \
--cc=geert@linux-m68k.org \
--cc=jonas@southpole.se \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux@roeck-us.ne \
--cc=lkp@intel.com \
--cc=mattwu@163.com \
--cc=mingo@kernel.org \
--cc=palmer@rivosinc.com \
--cc=peterz@infradead.orgm \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=vgupta@kernel.org \
--cc=wuqiang.matt@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).