From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Markus Volk <f_l_k@t-online.de>, Martin Jansa <martin.jansa@gmail.com>
Cc: "openembedded-devel@lists.openembedded.org"
<openembedded-devel@lists.openembedded.org>
Subject: RE: [oe] [meta-oe][PATCH 1/2] malcontent-ui: add malcontent to RDEPENDS
Date: Wed, 15 May 2024 15:44:46 +0000 [thread overview]
Message-ID: <DB5PR02MB1021325F091D3D54A8F2FF356EFEC2@DB5PR02MB10213.eurprd02.prod.outlook.com> (raw)
In-Reply-To: <BUZFDS.4175JRWDQOCF@t-online.de>
[-- Attachment #1: Type: text/plain, Size: 2123 bytes --]
If libmalcontent-ui links with libmalcontent, then the malcontent-ui recipe should have a DEPENDS on malcontent, and you should not need to add an explicit RDEPENDS:${PN} for it (just as Martin wrote).
The reason I guess that you get that error is because I believe the malcontent-ui recipe has actually built libmalcontent itself (given that both recipes use the same source code) rather than using the one produced by the malcontent recipe (which malcontent-ui doesn't depend on...) Would it be an option to just have one recipe that builds both libraries and then packages them in different packages?
Also (since I now looked at the recipes), I would strongly recommend not to do:
FILES:${PN} = "${bindir} ${libdir} ${datadir}"
as you do in the malcontent-ui recipe, or:
FILES:${PN} += "${libdir} ${datadir}"
as you do in the malcontent recipe. Resetting FILES:${PN} (as in the first case) is always a source of problems and can easily lead to incorrect packaging of files. And for ${libdir} and ${datadir}, be more specific with what paths you are actually adding.
//Peter
From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Markus Volk
Sent: den 13 maj 2024 23:04
To: Martin Jansa <martin.jansa@gmail.com>
Cc: f_l_k@t-online.de; openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [meta-oe][PATCH 1/2] malcontent-ui: add malcontent to RDEPENDS
On Mon, May 13 2024 at 10:30:31 PM +02:00:00, Martin Jansa <martin.jansa@gmail.com<mailto:martin.jansa@gmail.com>> wrote:
If libmalcontent-ui-1.so.1 links with libmalcontent-0.so.0 then this should be build-time DEPENDS (and then shlibs code in do_package will automatically add malcontent to RDEPENDS.
This error is caused by adding malcontent to the DEPENDS field in PACKAGECONFIG like I did in gnome-control-center. After enabling this in my build the error occurred.
But in the end this RDPEND is not wrong I guess? I've split the package in two and without this RDEPEND it would be possible to install libmalcontent-ui without libmalcontent which would then be broken
[-- Attachment #2: Type: text/html, Size: 8863 bytes --]
next prev parent reply other threads:[~2024-05-15 15:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 20:08 [meta-oe][PATCH 1/2] malcontent-ui: add malcontent to RDEPENDS Markus Volk
2024-05-13 20:08 ` [meta-oe][PATCH 2/2] gnome-control-center: add PACKAGECONFIG for malcontent Markus Volk
2024-05-13 20:30 ` [oe] [meta-oe][PATCH 1/2] malcontent-ui: add malcontent to RDEPENDS Martin Jansa
2024-05-13 21:03 ` Markus Volk
2024-05-15 15:44 ` Peter Kjellerstedt [this message]
2024-05-16 17:58 ` Markus Volk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB5PR02MB1021325F091D3D54A8F2FF356EFEC2@DB5PR02MB10213.eurprd02.prod.outlook.com \
--to=peter.kjellerstedt@axis.com \
--cc=f_l_k@t-online.de \
--cc=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).