From: Khem Raj <raj.khem@gmail.com>
To: peter.marko@siemens.com
Cc: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
"openembedded-devel@lists.openembedded.org"
<openembedded-devel@lists.openembedded.org>
Subject: Re: [oe] [meta-oe][scarthgap][master][PATCH] re2: remove dev dependencies from main package
Date: Mon, 13 May 2024 09:37:22 -0700 [thread overview]
Message-ID: <CAMKF1sp8AKAxiZSFG+zBkbBF-GivsjzrC3Q+nHitQJrG7OVr5Q@mail.gmail.com> (raw)
In-Reply-To: <AS1PR10MB569796A83B44FB15E1C4DA9FFDE22@AS1PR10MB5697.EURPRD10.PROD.OUTLOOK.COM>
On Mon, May 13, 2024 at 12:07 AM Peter Marko via
lists.openembedded.org
<peter.marko=siemens.com@lists.openembedded.org> wrote:
>
> > > # Don't include so files in dev package -FILES:${PN}-dev =
> > > "${includedir} ${libdir}/cmake"
> > > +FILES:${PN}-dev = "${includedir} ${libdir}/cmake ${libdir}/pkgconfig"
> >
> > This wouldn't be needed if FILES:${PN} wasn't set using FILES:${PN} = "${libdir}" earlier.
> >
> > A better way to achieve that *.so files are packaged in the base package is to do:
> >
> > SOLIBS = ".so*"
> > FILES_SOLIBSDEV = ""
> > INSANE_SKIP:${PN} += "dev-so"
> >
>
> The patch is already merged, so I'm not sending a v2 anymore
Please address the feedback in a new patch since it is an improvement,
your patch fixed an issue and was in a merge queue
that has been through a few CI cycles already, so I did not remove it,
however, that does not mean that it can not be improved upon.
but thanks for the hint for my future patches.
> I wanted to do the least intrusive change as I don't understand why the solibsdev are needed in the main package.
> And larger reworks usually trigger those kind of discussions which I was not ready to answer.
>
> Peter
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#110335): https://lists.openembedded.org/g/openembedded-devel/message/110335
> Mute This Topic: https://lists.openembedded.org/mt/105978716/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
prev parent reply other threads:[~2024-05-13 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 11:16 [meta-oe][scarthgap][master][PATCH] re2: remove dev dependencies from main package Peter Marko
2024-05-12 13:13 ` [oe] " Peter Kjellerstedt
2024-05-13 7:07 ` Marko, Peter
2024-05-13 16:37 ` Khem Raj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMKF1sp8AKAxiZSFG+zBkbBF-GivsjzrC3Q+nHitQJrG7OVr5Q@mail.gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=peter.kjellerstedt@axis.com \
--cc=peter.marko@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).