From: Xiangyu Chen <xiangyu.chen@eng.windriver.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [oe][meta-oe][PATCH] libgpiod: fix QA error in ptest RDEPENDS
Date: Tue, 9 Apr 2024 10:24:16 +0800 [thread overview]
Message-ID: <8527cf1b-bc40-4310-9d22-96daf37e3004@eng.windriver.com> (raw)
In-Reply-To: <CAMKF1soVBNOQpqiZn-m-MeeEm6ERm-7t-FKWbKiY+MEGsE0+eg@mail.gmail.com>
On 4/9/24 00:12, Khem Raj wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On Mon, Apr 8, 2024 at 1:47 AM Xiangyu Chen
> <xiangyu.chen@eng.windriver.com> wrote:
>> From: Xiangyu Chen <xiangyu.chen@windriver.com>
>>
>> The bash in ptest RDEPENDS would cause following QA error:
>>
>> ERROR: QA Issue: lib32-libgpiod package lib32-libgpiod-ptest-dev -
>> suspicious values 'bash-dev' in RRECOMMENDS [multilib]
>>
>> Add a ptest enable dependency to avoid this QA error happens.
>>
>> Signed-off-by: Xiangyu Chen <xiangyu.chen@windriver.com>
>> ---
>> meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb b/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb
>> index c62c9a3567..4a568b4fbe 100644
>> --- a/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb
>> +++ b/meta-oe/recipes-support/libgpiod/libgpiod_2.1.1.bb
>> @@ -21,7 +21,7 @@ FILES:${PN}-ptest += "${libdir}/libgpiosim.so.*"
>> FILES:${PN}-ptest-dev += "${includedir}/gpiosim.h"
>>
>> RDEPENDS:${PN}-ptest += " \
>> - bash \
>> + ${@bb.utils.contains('PTEST_ENABLED', '1', 'bash', '', d)} \
> This check is already available below, so just add it next to shunit2
Thanks for your suggestion, a v2 patch has been sent to maillist, could
you revert current patch on yoe/mut?
https://git.openembedded.org/meta-openembedded-contrib/commit/?h=yoe/mut&id=d3a20f5d7ea5a85c1d0fb298a6f3fc93dff0e828
thanks!
>
>> ${@bb.utils.contains('PTEST_ENABLED', '1', 'shunit2', '', d)} \
>> "
>> RRECOMMENDS:${PN}-ptest += "kernel-module-gpio-sim kernel-module-configfs"
>> --
>> 2.35.5
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#109861): https://lists.openembedded.org/g/openembedded-devel/message/109861
>> Mute This Topic: https://lists.openembedded.org/mt/105397634/1997914
>> Group Owner: openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
prev parent reply other threads:[~2024-04-09 2:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 9:26 [oe][meta-oe][PATCH] libgpiod: fix QA error in ptest RDEPENDS Xiangyu Chen
2024-04-08 16:12 ` Khem Raj
2024-04-09 2:24 ` Xiangyu Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8527cf1b-bc40-4310-9d22-96daf37e3004@eng.windriver.com \
--to=xiangyu.chen@eng.windriver.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).