From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] oeqa/selftest/devtool: Fix for usrmerge in DISTRO_FEATURES
Date: Wed, 08 May 2024 09:09:36 +0100 [thread overview]
Message-ID: <517ccf945dfd477b025e38fca5d01aa7365c2958.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAMKF1sqYVDCdAOez+fYa8_pHxbDNW1n8U3doJtKM33hfer0dag@mail.gmail.com>
On Tue, 2024-05-07 at 15:50 -0700, Khem Raj wrote:
>
>
> On Tue, May 7, 2024 at 3:47 PM Richard Purdie via
> lists.openembedded.org
> <richard.purdie=linuxfoundation.org@lists.openembedded.org> wrote:
> > If usrmerge is in DISTRO_FEATURES, assumptions in one of the tests
> > would
> > fail. Improve the test so it works in both cases.
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> > meta/lib/oeqa/selftest/cases/devtool.py | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/lib/oeqa/selftest/cases/devtool.py
> > b/meta/lib/oeqa/selftest/cases/devtool.py
> > index c8f9534e416..882225dde34 100644
> > --- a/meta/lib/oeqa/selftest/cases/devtool.py
> > +++ b/meta/lib/oeqa/selftest/cases/devtool.py
> > @@ -1773,6 +1773,8 @@ class DevtoolExtractTests(DevtoolBase):
> > # Definitions
> > testrecipe = 'mdadm'
> > testfile = '/sbin/mdadm'
> > + if "usrmerge" in get_bb_var('DISTRO_FEATURES'):
> > + testfile = '/usr/sbin/mdadm'
> > testimage = 'oe-selftest-image'
> > testcommand = '/sbin/mdadm --help'
> >
>
>
> Won’t this line also need to be covered as well ?
> I wonder if these paths need to be absolute or can they be searched
> in standard paths
>
Good question. I checked and it works due to the symlink present but it
would probably look better if that is tweaked as well.
Cheers,
Richard
prev parent reply other threads:[~2024-05-08 8:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 22:47 [PATCH] oeqa/selftest/devtool: Fix for usrmerge in DISTRO_FEATURES Richard Purdie
2024-05-07 22:50 ` [OE-core] " Khem Raj
2024-05-08 8:09 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517ccf945dfd477b025e38fca5d01aa7365c2958.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).