From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
To: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] kernel-fitImage: use IMAGE_NAME_SUFFIX
Date: Wed, 08 May 2024 14:21:27 +0200 [thread overview]
Message-ID: <2e8a718dd39f7fc89b34c91e552a6ba1fa658572.camel@pengutronix.de> (raw)
In-Reply-To: <20240430102448.1068114-1-r.czerwinski@pengutronix.de>
Hi,
please disregard this patch. Apparently the convention is for initramfs
images to set IMAGE_NAME_SUFFIX ?= "", which lets kernel-
fitimage.bbclass work as expected.
Best regards,
Rouven
On Tue, 2024-04-30 at 12:24 +0200, Rouven Czerwinski wrote:
> Without taking IMAGE_NAME_SUFFIX into account, the kernel-fitimage
> class
> will always fail to find the initramfs, fix the search path and error
> message to include IMAGE_NAME_SUFFIX.
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> meta/classes-recipe/kernel-fitimage.bbclass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes-recipe/kernel-fitimage.bbclass
> b/meta/classes-recipe/kernel-fitimage.bbclass
> index 4b74ddc201..e0a26d26b9 100644
> --- a/meta/classes-recipe/kernel-fitimage.bbclass
> +++ b/meta/classes-recipe/kernel-fitimage.bbclass
> @@ -683,7 +683,7 @@ fitimage_assemble() {
> # Find and use the first initramfs image archive
> type we find
> found=
> for img in ${FIT_SUPPORTED_INITRAMFS_FSTYPES}; do
> -
> initramfs_path="${DEPLOY_DIR_IMAGE}/${INITRAMFS_IMAGE_NAME}.$img"
> + initramfs_path="${DEPLOY_DIR_IMAGE}/${INITRA
> MFS_IMAGE_NAME}${IMAGE_NAME_SUFFIX}.$img"
> if [ -e "$initramfs_path" ]; then
> bbnote "Found initramfs image:
> $initramfs_path"
> found=true
> @@ -695,7 +695,7 @@ fitimage_assemble() {
> done
>
> if [ -z "$found" ]; then
> - bbfatal "Could not find a valid initramfs
> type for ${INITRAMFS_IMAGE_NAME}, the supported types are:
> ${FIT_SUPPORTED_INITRAMFS_FSTYPES}"
> + bbfatal "Could not find a valid initramfs
> type for ${INITRAMFS_IMAGE_NAME}${IMAGE_NAME_SUFFIX}, the supported
> types are: ${FIT_SUPPORTED_INITRAMFS_FSTYPES}"
> fi
> fi
>
>
> base-commit: 7ef767d84d56b25498e45db83bb8f9d9caebeaf9
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#198759):
> https://lists.openembedded.org/g/openembedded-core/message/198759
> Mute This Topic: https://lists.openembedded.org/mt/105818094/3620320
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe:
> https://lists.openembedded.org/g/openembedded-core/unsub [
> rcz@pengutronix.de]
> -=-=-=-=-=-=-=-=-=-=-=-
>
prev parent reply other threads:[~2024-05-08 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 10:24 [PATCH] kernel-fitImage: use IMAGE_NAME_SUFFIX Rouven Czerwinski
2024-05-08 12:21 ` Rouven Czerwinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e8a718dd39f7fc89b34c91e552a6ba1fa658572.camel@pengutronix.de \
--to=r.czerwinski@pengutronix.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).