From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Brendan Higgins <brendan.higgins@linux.dev>,
Joel Stanley <joel@jms.id.au>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH 05/64] i2c: aspeed: reword according to newest specification
Date: Mon, 8 Apr 2024 10:35:52 +0200 [thread overview]
Message-ID: <wcnu6qxxztplzpqtqc4t3bf53v6buto6ch6b5l5xoytrxxdgjz@gwzlifzzfrvx> (raw)
In-Reply-To: <vb4hempklviz6w4gd3eimprplybm4ckefwz2gyy7cp2uww2anv@b4egbq4u4rrg>
[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]
> > -static int aspeed_i2c_master_xfer(struct i2c_adapter *adap,
> > +static int aspeed_i2c_xfer(struct i2c_adapter *adap,
> > struct i2c_msg *msgs, int num)
>
> here the alignment goes a bi off.
Thanks, I missed this.
> > #if IS_ENABLED(CONFIG_I2C_SLAVE)
> > /* precondition: bus.lock has been acquired. */
> > -static void __aspeed_i2c_reg_slave(struct aspeed_i2c_bus *bus, u16 slave_addr)
> > +static void __aspeed_i2c_reg_target(struct aspeed_i2c_bus *bus, u16 slave_addr)
>
> We have the word master/slave forgotten here and there, but as
> we are here, /slave_addr/target_addr/
I can do this now. My plan was to convert it when I convert the whole
CONFIG_I2C_SLAVE interface. But "since we are here" can be argued.
> > static const struct i2c_algorithm aspeed_i2c_algo = {
> > - .master_xfer = aspeed_i2c_master_xfer,
> > + .xfer = aspeed_i2c_xfer,
>
> here the alignment goes a bit off.
I also wanted to fix this afterwards together with all the tab-indented
struct declarations in busses/. But maybe I better do the tab-removal
series beforehand? Would you accept such a thing?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-04-08 23:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240322132619.6389-1-wsa+renesas@sang-engineering.com>
2024-03-23 9:20 ` [PATCH 00/64] i2c: reword i2c_algorithm according to newest specification Andi Shyti
2024-03-26 0:36 ` Andi Shyti
2024-04-05 8:48 ` Wolfram Sang
[not found] ` <20240322132619.6389-6-wsa+renesas@sang-engineering.com>
2024-03-25 2:29 ` [PATCH 05/64] i2c: aspeed: reword " Andrew Jeffery
2024-03-26 0:17 ` Andi Shyti
2024-04-08 8:35 ` Wolfram Sang [this message]
[not found] ` <20240322132619.6389-21-wsa+renesas@sang-engineering.com>
2024-03-26 20:08 ` [PATCH 20/64] i2c: fsi: " Andi Shyti
[not found] ` <20240322132619.6389-65-wsa+renesas@sang-engineering.com>
2024-03-22 16:09 ` [PATCH 64/64] i2c: reword i2c_algorithm in drivers " Andy Shevchenko
[not found] ` <Zf22dmwBpN7Ctk3v@shikoro>
2024-03-22 17:00 ` Andy Shevchenko
2024-04-02 12:35 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wcnu6qxxztplzpqtqc4t3bf53v6buto6ch6b5l5xoytrxxdgjz@gwzlifzzfrvx \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=brendan.higgins@linux.dev \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).