From: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>
To: "patrick@stwcx.xyz" <patrick@stwcx.xyz>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
openbmc_compute <openbmc_compute@meta.com>
Cc: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>
Subject: An issue about the architecture of pldmd when implementing Set/Get Boot Order for YV4 platform
Date: Mon, 29 Jan 2024 02:56:08 +0000 [thread overview]
Message-ID: <PSAPR04MB4598EBB5B5AD6109855C0D9BA57E2@PSAPR04MB4598.apcprd04.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1884 bytes --]
Hi Patrick,
In previous projects, e.g., YV35, BICs bridge the IPMI command of Set/Get Boot Order sent from BIOS directly to the BMC, but in YV4, IPMI command is replaced by PLDM.
As a result, we plan to translate the OEM IPMI command: Set (NetFn=0x30, Cmd=0x52) and Get (NetFn=0x30, Cmd=0x53) Boot Order sent from BIOS into standard command "SetBIOSAttributeCurrentValue" and "GetBIOSAttributeCurrentValueByHandle" in PLDM for BIOS Control and Configuration (DSP0247).
Currently, the handlers for the 2 commands above have been implemented in pldmd to set/get the current value of a BIOSAttribute. (libpldmresponder/bios.cpp<https://github.com/openbmc/pldm/blob/9e6631e201cf71895491987d93e8a343e05783b5/libpldmresponder/bios.cpp#L104>)
Each BIOSAttribute can be different AttributeTypes, BIOSEnumeration, BIOSString, and BIOSInteger have been implemented. We want to add a new type "BIOSBootConfigSetting". (Can refer to Table 14: PLDM Representation of BIOSAttributeValueTableData in DSP0247<https://www.dmtf.org/sites/default/files/standards/documents/DSP0247_1.0.0.pdf>)
When Set/Get command comes in, it will find specific BIOSAttribute by searching the BIOSTable (i.e., BIOSTableObj at libpldmresponder/bios_config.hpp<https://github.com/openbmc/pldm/blob/9e6631e201cf71895491987d93e8a343e05783b5/libpldmresponder/bios_config.hpp#L53>), there are CurrentValue and DefaultValue and OptionValue to represent the attribute's value (a few lines above to BIOSTableObj), but the type is restricted to int64_t and string, which has only 1 element.
BootConfigSetting is a series of BootSources, which should be a string array. We want to add string array to let BootConfigSetting can store multiple elements and add into BIOSTableObj. Since change the type of data type might need a good amount of work, we wonder know if there is any concern to do it?
Thanks,
Delphine
[-- Attachment #2: Type: text/html, Size: 4677 bytes --]
reply other threads:[~2024-01-29 2:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PSAPR04MB4598EBB5B5AD6109855C0D9BA57E2@PSAPR04MB4598.apcprd04.prod.outlook.com \
--to=delphine_cc_chiu@wiwynn.com \
--cc=openbmc@lists.ozlabs.org \
--cc=openbmc_compute@meta.com \
--cc=patrick@stwcx.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).