From: ChiaWei Wang <chiawei_wang@aspeedtech.com>
To: Conor Dooley <conor@kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"zev@bewilderbeest.net" <zev@bewilderbeest.net>,
Ryan Chen <ryan_chen@aspeedtech.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
Richard Weinberger <richard@nod.at>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Joel Stanley <joel@jms.id.au>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
"jk@codeconstruct.com.au" <jk@codeconstruct.com.au>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Manojkiran Eda <manojkiran.eda@gmail.com>
Subject: RE: 回覆: [PATCH] Add eSPI device driver (flash channel)
Date: Sun, 18 Feb 2024 09:36:27 +0000 [thread overview]
Message-ID: <KL1PR06MB6652F1A2D8652B727D5F581A91522@KL1PR06MB6652.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <20240215-probable-gimmick-83d5dcbc4729@spud>
> From: Conor Dooley <conor@kernel.org>
> Sent: Friday, February 16, 2024 1:13 AM
>
> On Thu, Feb 15, 2024 at 01:56:00AM +0000, ChiaWei Wang wrote:
> > >
> > > On Wed, Feb 14, 2024 at 11:34:31AM +0000, ChiaWei Wang wrote:
> > > > We appreciate that you are willing to help on the open source
> contribution.
> > > > However, please co-work with Aspeed before submitting drivers of
> > > > Aspeed
> > > HW.
> > > > Otherwise, a misleading driver on the community are going to bring
> > > > tons of
> > > customer issues to Aspeed.
> > >
> > > It may not apply in this particular case as Aspeed did write the
> > > original driver and it is polite to work with previous authors when
> > > respinning a patchset, but in general there is no need to work with
> > > a hardware vendor before writing drivers for their hardware.
> > >
> > > Blocking a driver because that company might receive more support
> > > requests is not the kernel's problem.
> >
> > I agree with that and Aspeed will not refuse to support.
> >
> > However, in this case, the authors, IBM, and Aspeed already have discussion
> (at least 4 times) before and foresee "issues" on practical eSPI SAFS use.
> > If there is already a known issue of the driver, why ignoring the previous
> discussion and push it?
> > A compromise is to ask for driver renaming to espi-mafs to avoid confusion.
> > Otherwise we need to explain, again, why the driver does not fulfill the SAFS
> expectation.
>
> To be clear, in case you misunderstood, I was making a general point and not
> about this particular patchset.
Thanks for the clarification and I understand your point.
Most Aspeed-related drivers are from the Aspeed SDK.
And we keep revising the SDK based on our customers' feedback and issues reported.
We only wish that the version submitted to the community will not result in unnecessary misunderstanding and thus more customer issues.
Regards,
Chiawei
next prev parent reply other threads:[~2024-02-18 9:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 14:36 [PATCH] Add eSPI device driver (flash channel) Manojkiran Eda
2024-02-13 15:40 ` Rob Herring
2024-02-13 22:28 ` Rob Herring
2024-02-14 11:34 ` 回覆: " ChiaWei Wang
2024-02-14 18:31 ` Conor Dooley
2024-02-15 1:56 ` ChiaWei Wang
2024-02-15 17:12 ` Conor Dooley
2024-02-18 9:36 ` ChiaWei Wang [this message]
2024-02-16 10:20 ` Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=KL1PR06MB6652F1A2D8652B727D5F581A91522@KL1PR06MB6652.apcprd06.prod.outlook.com \
--to=chiawei_wang@aspeedtech.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jk@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=manojkiran.eda@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=openbmc@lists.ozlabs.org \
--cc=patrick.rudolph@9elements.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=vigneshr@ti.com \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).