From: Linus Walleij <linus.walleij@linaro.org>
To: Jim Liu <jim.t90615@gmail.com>
Cc: andy@kernel.org, robh@kernel.org, benjaminfair@google.com,
devicetree@vger.kernel.org, brgl@bgdev.pl, JJLIU0@nuvoton.com,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, openbmc@lists.ozlabs.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v7 3/3] gpio: nuvoton: Add Nuvoton NPCM sgpio driver
Date: Thu, 2 Nov 2023 13:49:09 +0100 [thread overview]
Message-ID: <CACRpkdZgqfzti8KW25m++VG2GhU7LZCgzxeWW+uaNO7rh1kmjg@mail.gmail.com> (raw)
In-Reply-To: <20231101025110.1704543-4-jim.t90615@gmail.com>
Hi Jim,
thanks for your patch!
I saw that Andy already provided some good feedback but couldn't help
but to notice this:
On Wed, Nov 1, 2023 at 3:52 AM Jim Liu <jim.t90615@gmail.com> wrote:
> Changes for v6:
> - Remove bus-frequency property set
> - Use GPIO_GENERIC
(...)
> +config GPIO_NPCM_SGPIO
> + bool "Nuvoton SGPIO support"
> + depends on (ARCH_NPCM || COMPILE_TEST) && OF_GPIO
> + select GPIO_GENERIC
You select GPIO_GENERIC but you don't actually use it.
If you were using it, your code would be calling bgpio_init()
and it does not.
Yours,
Linus Walleij
prev parent reply other threads:[~2023-11-02 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 2:51 [PATCH v7 0/3] Add Nuvoton NPCM SGPIO feature Jim Liu
2023-11-01 2:51 ` [PATCH v7 1/3] dt-bindings: gpio: add NPCM sgpio driver bindings Jim Liu
2023-11-01 2:51 ` [PATCH v7 2/3] arm: dts: nuvoton: npcm: Add sgpio feature Jim Liu
2023-11-01 2:51 ` [PATCH v7 3/3] gpio: nuvoton: Add Nuvoton NPCM sgpio driver Jim Liu
2023-11-02 12:23 ` Andy Shevchenko
2023-11-02 12:49 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZgqfzti8KW25m++VG2GhU7LZCgzxeWW+uaNO7rh1kmjg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=JJLIU0@nuvoton.com \
--cc=andy@kernel.org \
--cc=benjaminfair@google.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=jim.t90615@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).