From: Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
To: Rob Herring <robh@kernel.org>, Guenter Roeck <linux@roeck-us.net>,
Chanh Nguyen <chanh@os.amperecomputing.com>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
Conor Dooley <conor+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Thang Nguyen <thang@os.amperecomputing.com>,
linux-kernel@vger.kernel.org,
Phong Vo <phong@os.amperecomputing.com>,
Justin Ledford <justinledford@google.com>,
Quan Nguyen <quan@os.amperecomputing.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Open Source Submission <patches@amperecomputing.com>
Subject: Re: [PATCH 3/3] dt-bindings: hwmon: max31790: Add pwmout-pin-as-tach-input property
Date: Tue, 26 Mar 2024 17:33:17 +0700 [thread overview]
Message-ID: <44d2e865-ee88-4054-a94e-06c6098bb0e1@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <ce8b2b49-b194-42f7-8f83-fcbf7b460970@amperemail.onmicrosoft.com>
On 18/03/2024 16:53, Chanh Nguyen wrote:
>
>
> On 12/03/2024 00:34, Rob Herring wrote:
>> On Mon, Mar 11, 2024 at 06:13:47PM +0700, Chanh Nguyen wrote:
>>> Add pwmout-pin-as-tach-input property.
>>>
>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>>> ---
>>> Documentation/devicetree/bindings/hwmon/max31790.yaml | 11 +++++++++++
>>> 1 file changed, 11 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/max31790.yaml
>>> b/Documentation/devicetree/bindings/hwmon/max31790.yaml
>>> index 5a93e6bdebda..447cac17053a 100644
>>> --- a/Documentation/devicetree/bindings/hwmon/max31790.yaml
>>> +++ b/Documentation/devicetree/bindings/hwmon/max31790.yaml
>>> @@ -25,6 +25,16 @@ properties:
>>> reg:
>>> maxItems: 1
>>> + pwmout-pin-as-tach-input:
>>> + description: |
>>> + An array of six integers responds to six PWM channels for
>>> + configuring the pwm to tach mode.
>>> + When set to 0, the associated PWMOUT produces a PWM waveform for
>>> + control of fan speed. When set to 1, PWMOUT becomes a TACH input
>>> + $ref: /schemas/types.yaml#/definitions/uint8-array
>>> + maxItems: 6
>>> + minItems: 6
>>
>> Seems incomplete. For example, fan tachs have different number of
>> pulses per revolution, don't you need to know that too?
>>
>> There's a common fan binding now (or pending). You should use that and
>> this property won't be needed.
>>
>> Rob
>
> Thank Rob,
>
> I checked in the
> Documentation/devicetree/bindings/hwmon/fan-common.yaml. I found the
> tach-ch property, but it seems define the tach channel used for fan.
>
> tach-ch:
> description:
> The tach channel used for the fan.
> $ref: /schemas/types.yaml#/definitions/uint8-array
>
> I would like to define a new vendor property to configure the PWM-OUT
> pin to become a TACH-IN pin. So I introduce the
> "maxim,pwmout-pin-as-tach-input" property. Please help me share your
> comments!
Hi Guenter and Rob,
I'm preparing for patch v2. I'm looking forward to hear your advice.
Should I use the "tach-ch" property (a common fan property) or define
new vendor property ("maxim,pwmout-pin-as-tach-input") for my purpose?
Thank you very much!
Chanh
next prev parent reply other threads:[~2024-03-26 10:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 11:13 [PATCH 0/3] Update the max31790 driver Chanh Nguyen
2024-03-11 11:13 ` [PATCH 1/3] dt-bindings: hwmon: Add maxim max31790 driver bindings Chanh Nguyen
[not found] ` <6fb70adb-aa85-4b9c-b093-afa4ec7ed056@linaro.org>
2024-03-18 9:51 ` Chanh Nguyen
[not found] ` <a224e752-d99b-45d3-b5db-761a698c347e@linaro.org>
2024-03-22 9:53 ` Chanh Nguyen
[not found] ` <c3f296d2-63b0-493e-a2cd-5010dea84adb@linaro.org>
2024-03-26 10:26 ` Chanh Nguyen
2024-03-11 11:13 ` [PATCH 2/3] hwmon: (max31790): Support config PWM output becomes TACH Chanh Nguyen
2024-03-11 11:13 ` [PATCH 3/3] dt-bindings: hwmon: max31790: Add pwmout-pin-as-tach-input property Chanh Nguyen
2024-03-11 17:34 ` Rob Herring
2024-03-11 17:52 ` Guenter Roeck
2024-03-18 9:54 ` Chanh Nguyen
2024-03-18 9:53 ` Chanh Nguyen
2024-03-26 10:33 ` Chanh Nguyen [this message]
[not found] ` <9d1207f1-4941-4f2a-99d6-371f5b4709f5@linaro.org>
2024-03-18 9:48 ` Chanh Nguyen
[not found] ` <7252305b-4c7c-4cec-8ef1-8bf96293b469@linaro.org>
2024-03-18 16:50 ` Chanh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44d2e865-ee88-4054-a94e-06c6098bb0e1@amperemail.onmicrosoft.com \
--to=chanh@amperemail.onmicrosoft.com \
--cc=chanh@os.amperecomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=justinledford@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=quan@os.amperecomputing.com \
--cc=robh@kernel.org \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).