From: Rob Herring <robh@kernel.org>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: devicetree@vger.kernel.org, p.zabel@pengutronix.de,
sboyd@kernel.org, venture@google.com, mturquette@baylibre.com,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
tali.perry1@gmail.com, joel@jms.id.au,
krzysztof.kozlowski+dt@linaro.org, openbmc@lists.ozlabs.org,
benjaminfair@google.com
Subject: Re: [PATCH v24 1/4] dt-bindings: reset: npcm: add clock properties
Date: Mon, 13 May 2024 10:51:54 -0500 [thread overview]
Message-ID: <20240513155154.GA2595523-robh@kernel.org> (raw)
In-Reply-To: <20240509192411.2432066-2-tmaimon77@gmail.com>
On Thu, May 09, 2024 at 10:24:08PM +0300, Tomer Maimon wrote:
> Adding 25MHz reference clock and clock-cell properties to NPCM reset
> document due to the registration of the npcm8xx clock auxiliary bus device
> in the NPCM reset driver
>
> The NPCM8xx clock auxiliary bus device has been registered in the NPCM
> reset driver because the reset and the clock share the same register
> region.
auxiliary bus is a Linux concept. The reasoning for this should be the
reset block also provides clocks.
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> .../bindings/reset/nuvoton,npcm750-reset.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml b/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml
> index d82e65e37cc0..18db4de13098 100644
> --- a/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml
> +++ b/Documentation/devicetree/bindings/reset/nuvoton,npcm750-reset.yaml
> @@ -21,6 +21,13 @@ properties:
> '#reset-cells':
> const: 2
>
> + '#clock-cells':
> + const: 1
> +
> + clocks:
> + items:
> + - description: specify external 25MHz referance clock.
s/referance/reference/
> +
> nuvoton,sysgcr:
> $ref: /schemas/types.yaml#/definitions/phandle
> description: a phandle to access GCR registers.
> @@ -39,6 +46,17 @@ required:
> - '#reset-cells'
> - nuvoton,sysgcr
>
> +if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - nuvoton,npcm845-reset
> +then:
> + required:
> + - '#clock-cells'
> + - clocks
New required properties are an ABI break. Please justify why that's okay
for this platform in the commit message (assuming that it is).
Rob
next prev parent reply other threads:[~2024-05-13 15:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 19:24 [PATCH v24 0/4] Introduce Nuvoton Arbel NPCM8XX BMC SoC Tomer Maimon
2024-05-09 19:24 ` [PATCH v24 1/4] dt-bindings: reset: npcm: add clock properties Tomer Maimon
2024-05-13 15:51 ` Rob Herring [this message]
2024-05-16 9:47 ` Tomer Maimon
2024-05-09 19:24 ` [PATCH v24 2/4] reset: npcm: register npcm8xx clock auxiliary bus device Tomer Maimon
2024-05-10 10:33 ` kernel test robot
2024-05-10 11:25 ` kernel test robot
2024-05-10 11:25 ` kernel test robot
2024-05-09 19:24 ` [PATCH v24 3/4] clk: npcm8xx: add clock controller Tomer Maimon
2024-05-09 19:24 ` [PATCH v24 4/4] dt-binding: clock: remove nuvoton npcm845-clk bindings Tomer Maimon
2024-05-13 15:53 ` Rob Herring
2024-05-16 9:44 ` Tomer Maimon
2024-05-22 16:34 ` Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513155154.GA2595523-robh@kernel.org \
--to=robh@kernel.org \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).