From: Quan Nguyen <quan@os.amperecomputing.com>
To: Brendan Higgins <brendan.higgins@linux.dev>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>, Andi Shyti <andi.shyti@kernel.org>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Wolfram Sang <wsa@kernel.org>,
Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: Cosmo Chou <chou.cosmo@gmail.com>,
Open Source Submission <patches@amperecomputing.com>,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>
Subject: [PATCH v4 0/2] i2c: aspeed: Late ack Tx done irqs and handle coalesced start with stop conditions
Date: Mon, 11 Dec 2023 17:22:15 +0700 [thread overview]
Message-ID: <20231211102217.2436294-1-quan@os.amperecomputing.com> (raw)
This series consists of two patches to handle the below issues observed
when testing with slave mode:
+ The coalesced stop condition with the start conditions
+ Early ack'ed of Tx done (ACK and NAK) causing "Unexpected Ack on
read request".
This series was verified with ast2500 and ast2600.
The prior discussion could be found at:
https://lore.kernel.org/all/20231208033142.1673232-1-quan@os.amperecomputing.com/
v4:
+ Switch to use define macro instead of variable [Andrew]
+ Make the early ack conditionally to avoid unnecessary
writel()/readl() [Quan]
+ Add an extra empty line before the comment in patch 1 [Andrew]
v3:
+ Fix the unconditional write when ack the irqs [Andrew]
+ Handle the coalesced stop condition with the
start conditions [Andrew]
+ Refactor the code to enhance code readability [Quan]
+ Revised commit message [Quan]
v2:
+ Split these patches to separate series [Joel]
+ Added the Fixes lines [Joel]
+ Fixed multiline comment [Joel]
+ Refactor irq clearing code [Joel, Guenter]
+ Revised commit message [Joel, Quan]
v1:
+ These patches are first introduced from this disscusstion
https://lore.kernel.org/all/20210519074934.20712-1-quan@os.amperecomputing.com/
Quan Nguyen (2):
i2c: aspeed: Handle the coalesced stop conditions with the start
conditions.
i2c: aspeed: Acknowledge Tx done with and without ACK irq late
drivers/i2c/busses/i2c-aspeed.c | 75 +++++++++++++++++++++++----------
1 file changed, 52 insertions(+), 23 deletions(-)
--
2.35.1
next reply other threads:[~2023-12-11 10:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 10:22 Quan Nguyen [this message]
2023-12-11 10:22 ` [PATCH v4 1/2] i2c: aspeed: Handle the coalesced stop conditions with the start conditions Quan Nguyen
2023-12-15 1:42 ` Andi Shyti
2023-12-19 20:55 ` Wolfram Sang
2023-12-11 10:22 ` [PATCH v4 2/2] i2c: aspeed: Acknowledge Tx done with and without ACK irq late Quan Nguyen
2023-12-11 23:03 ` Andrew Jeffery
2023-12-14 22:21 ` Andrew Jeffery
2023-12-18 8:45 ` Quan Nguyen
2023-12-18 23:02 ` Andrew Jeffery
2023-12-15 1:45 ` Andi Shyti
2023-12-12 2:39 ` [PATCH v4 0/2] i2c: aspeed: Late ack Tx done irqs and handle coalesced start with stop conditions Joel Stanley
2023-12-12 5:02 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211102217.2436294-1-quan@os.amperecomputing.com \
--to=quan@os.amperecomputing.com \
--cc=andi.shyti@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=benh@kernel.crashing.org \
--cc=brendan.higgins@linux.dev \
--cc=chou.cosmo@gmail.com \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=thang@os.amperecomputing.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).