From: Quan Nguyen <quan@os.amperecomputing.com>
To: Brendan Higgins <brendan.higgins@linux.dev>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>, Andi Shyti <andi.shyti@kernel.org>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Wolfram Sang <wsa@kernel.org>,
Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: Cosmo Chou <chou.cosmo@gmail.com>,
Open Source Submission <patches@amperecomputing.com>,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>
Subject: [PATCH v2 RESEND 0/2] i2c: aspeed: Late ack Tx done irqs and fix unhandled Tx done with NAK
Date: Tue, 28 Nov 2023 14:52:34 +0700 [thread overview]
Message-ID: <20231128075236.2724038-1-quan@os.amperecomputing.com> (raw)
Rebase on the v6.7-rc3 and resend the series as per discussion at
https://lore.kernel.org/all/d0773df55a6fe8a5c9b1a3d7c8dd2e1343643272.camel@codeconstruct.com.au/
The prior discussion could be found at
https://lore.kernel.org/all/20210616031046.2317-1-quan@os.amperecomputing.com/
This series consists of two patches to fix the below issues observed
when testing with slave mode:
+ Unhandled Tx done with NAK
+ Early ack'ed of Tx done (ACK and NAK) causing "Unexpected Ack on
read request".
v2:
+ Split these patches to separate series [Joel]
+ Added the Fixes lines [Joel]
+ Fixed multiline comment [Joel]
+ Refactor irq clearing code [Joel, Guenter]
+ Revised commit message [Joel, Quan]
v1:
+ These patches are first introduced from this disscusstion
https://lore.kernel.org/all/20210519074934.20712-1-quan@os.amperecomputing.com/
Quan Nguyen (2):
i2c: aspeed: Fix unhandled Tx done with NAK
i2c: aspeed: Acknowledge Tx done with and without ACK irq late
drivers/i2c/busses/i2c-aspeed.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
--
2.35.1
next reply other threads:[~2023-11-28 7:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 7:52 Quan Nguyen [this message]
2023-11-28 7:52 ` [PATCH v2 RESEND 1/2] i2c: aspeed: Fix unhandled Tx done with NAK Quan Nguyen
2023-11-29 0:19 ` Andrew Jeffery
2023-11-29 9:03 ` Quan Nguyen
2023-11-30 1:20 ` Andrew Jeffery
2023-11-30 6:52 ` Quan Nguyen
2023-11-29 0:35 ` Andi Shyti
2023-11-29 9:03 ` Quan Nguyen
2023-11-29 21:25 ` Andi Shyti
2023-11-30 6:53 ` Quan Nguyen
2023-11-28 7:52 ` [PATCH v2 RESEND 2/2] i2c: aspeed: Acknowledge Tx done with and without ACK irq late Quan Nguyen
2023-11-29 0:33 ` Andrew Jeffery
2023-11-29 9:02 ` Quan Nguyen
2023-11-29 22:44 ` Andrew Jeffery
2023-11-30 6:53 ` Quan Nguyen
2023-11-29 0:45 ` Andi Shyti
2023-11-29 9:05 ` Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128075236.2724038-1-quan@os.amperecomputing.com \
--to=quan@os.amperecomputing.com \
--cc=andi.shyti@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=benh@kernel.crashing.org \
--cc=brendan.higgins@linux.dev \
--cc=chou.cosmo@gmail.com \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=thang@os.amperecomputing.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).