From: Zev Weiss <zev@bewilderbeest.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Joel Stanley <joel@jms.id.au>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: aspeed: Add ASRock E3C256D4I BMC
Date: Wed, 15 Nov 2023 18:39:21 -0800 [thread overview]
Message-ID: <1e1c1493-d3f5-4c96-b85f-158d720b2ab5@hatter.bewilderbeest.net> (raw)
In-Reply-To: <863a0fe2-c258-47d9-8563-6f12bb55b4ad@linaro.org>
On Wed, Nov 15, 2023 at 04:13:29AM PST, Krzysztof Kozlowski wrote:
>On 14/11/2023 23:37, Zev Weiss wrote:
>
>>
>>>> + };
>>>> +
>>>> + memory@80000000 {
>>>> + reg = <0x80000000 0x20000000>;
>>>> + };
>>>> +
>>>> + leds {
>>>> + compatible = "gpio-leds";
>>>> +
>>>> + heartbeat {
>>>
>>> It does not look like you tested the DTS against bindings. Please run
>>> `make dtbs_check W=1` (see
>>> Documentation/devicetree/bindings/writing-schema.rst or
>>> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
>>> for instructions).
>
>The node names are clearly wrong and you got output. It's easy to spot
>if your patch worked in the first place:
>
> fatal error: dt-bindings/watchdog/aspeed-wdt.h: No such file or directory
>
The patch series was based on Linus's tree at the time I sent it; that
file was added in commit 9931be2cfca3 ("dt-bindings: watchdog:
aspeed-wdt: Add aspeed,reset-mask property"), which was included in the
6.7-rc1 tag, FWIW.
After some debugging I discovered that the reason I wasn't getting any
output from dtbs_check was that I had neglected to specify ARCH=arm when
invoking it, and when that defaulted to x86 it silently did a whole
bunch of nothing. It might be nice if something emitted some sort of
warning when invoked with nonsensical parameters (especially if I've
explicitly specified a dtstree=... argument pointing to arch/arm/...),
but oh well.
After re-running it with ARCH=arm, it produced a fairly voluminous spew
of output, though after combing through it all as best I can tell only
one or two lines of it actually pertain to the .dts in question itself
(the vast majority being from a .dtsi it #includes). I've fixed the one
remaining issue it reported (missing #address-cells and #size-cells on
the FRU eeprom node) and will post a v2 in the next few days (and
likewise on the spc621d8hm3 series).
Zev
prev parent reply other threads:[~2023-11-16 2:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 11:27 [PATCH 0/2] ARM: dts: aspeed: Add ASRock E3C256D4I BMC Zev Weiss
2023-11-14 11:27 ` [PATCH 1/2] dt-bindings: arm: aspeed: document ASRock E3C256D4I Zev Weiss
2023-11-14 11:27 ` [PATCH 2/2] ARM: dts: aspeed: Add ASRock E3C256D4I BMC Zev Weiss
[not found] ` <cde26249-1d47-496f-b198-a0c4c02bed5c@linaro.org>
2023-11-14 22:21 ` Zev Weiss
2023-11-14 22:37 ` Zev Weiss
2023-11-14 22:55 ` Zev Weiss
[not found] ` <863a0fe2-c258-47d9-8563-6f12bb55b4ad@linaro.org>
2023-11-16 2:39 ` Zev Weiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e1c1493-d3f5-4c96-b85f-158d720b2ab5@hatter.bewilderbeest.net \
--to=zev@bewilderbeest.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).