From: Denis Kenzior <denkenz@gmail.com>
To: ofono@lists.linux.dev
Subject: Re: [PATCH] qmi: Support dynamic service information
Date: Wed, 28 Feb 2024 09:26:12 -0600 [thread overview]
Message-ID: <accb7ecf-a059-433c-b145-52c407d05da1@gmail.com> (raw)
In-Reply-To: <20240227175739.1471333-1-denkenz@gmail.com>
On 2/27/24 11:57, Denis Kenzior wrote:
> On QMUX, service information is static. It is obtained via a CTL
> request and remains static for the duration of the connection. With
> QRTR, services can appear and disappear dynamically. Support this by
> converting the existing version_list / version_count member into a
> queue. struct qmi_version is now replaced by struct qmi_service_info
> with additional qrtr specific attributes.
> ---
> drivers/qmimodem/qmi.c | 118 +++++++++++++++++++++++------------------
> 1 file changed, 66 insertions(+), 52 deletions(-)
>
<snip>
Applied with the following change
> @@ -853,7 +881,7 @@ void qmi_device_free(struct qmi_device *device)
>
> l_hashmap_destroy(device->service_list, service_destroy);
>
> - l_free(device->version_list);
> + l_queue_destroy(device->service_infos, (l_queue_destroy_func_t) l_free);
This cast isn't necessary.
>
> if (device->shutting_down)
> device->destroyed = true;
Regards,
-Denis
prev parent reply other threads:[~2024-02-28 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 17:57 [PATCH] qmi: Support dynamic service information Denis Kenzior
2024-02-28 15:26 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=accb7ecf-a059-433c-b145-52c407d05da1@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).