From: Sergey Matyukevich <geomatsi@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 0/2] gemalto: netmon driver
Date: Tue, 12 Jan 2021 00:08:35 +0300 [thread overview]
Message-ID: <X/y+U7tgDxowIfyc@curiosity> (raw)
In-Reply-To: <d88b88b9-c250-5dd9-f361-ea348704392f@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1457 bytes --]
Hello Denis,
> > This patch series implements netmon driver for gemalto modems that are
> > able to provide basic measurements using AT+CQS and AT^SMONI commands.
> >
> > This patch series is intendedly marked as RFC. In addition to general
>
> I guess you mean intentionally here...
>
> > feedback for this v1 I would like to clarify the right way to handle
> > negative values that can be returned by modem. For instance, this
>
> So the short answer is: You're not supposed to even have negative numbers in
> AT commands. And since oFono follows 27.007, which is itself based on AT
> commands, negative numbers do not really exist at the API level.
>
> Refer to ITU v.250 Section 5.4.2.1 "Numeric constants". Strings are also
> supposed to be formatted in a certain way, which the firmware isn't doing
> properly either... The fact that you have to resort to using
> next_unquoted_string is kind of telling.
>
> > is the case for the values measured in dBm including EC/n0 and RSCP.
> > Currently such values are discarded by CELL_INFO_DICT_APPEND macro.
>
> I would guess your best bet would be to re-scale from what Gemalto firmware
> reports into something that 27.007 recommends. You may have to refer to
> 27.007, Section 8.69 to see what the scale is according to 3GPP.
Thanks a lot for pointing me in the right direction. I will get back
with v2 once I introduce the suggested changes.
Regards,
Sergey
prev parent reply other threads:[~2021-01-11 21:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 19:44 [RFC PATCH 0/2] gemalto: netmon driver Sergey Matyukevich
2021-01-10 19:44 ` [RFC PATCH 1/2] gemalto: add " Sergey Matyukevich
2021-01-11 19:28 ` Denis Kenzior
2021-01-10 19:44 ` [RFC PATCH 2/2] plugin: gemalto: enable netmon Sergey Matyukevich
2021-01-11 19:56 ` [RFC PATCH 0/2] gemalto: netmon driver Denis Kenzior
2021-01-11 21:08 ` Sergey Matyukevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/y+U7tgDxowIfyc@curiosity \
--to=geomatsi@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).