From: Denis Kenzior <denkenz@gmail.com>
To: adam@piggz.co.uk, ofono@lists.linux.dev
Subject: Re: [PATCH 4/4] qmimodem: voicecall: Implement DTMF tones
Date: Thu, 25 Apr 2024 15:30:07 -0500 [thread overview]
Message-ID: <9a55c6dc-597f-4601-b9cc-3962c47dcca9@gmail.com> (raw)
In-Reply-To: <2684478.lGaqSPkdTl@adam-laptop-hp>
Hi Adam,
On 4/25/24 2:07 PM, adam@piggz.co.uk wrote:
> On Tuesday 23 April 2024 22:54:57 BST Adam Pigg wrote:
>> So, I decided to have a re-think and try the burst dtmf method, which
>> accepts a string of chars, and should be simpler....
>>
Yeah, that's what I was wondering as well, whether this Burst DTMF command was
an easier approach.
>> I created a packet struct for the parameter data:
>> struct qmi_dtmf_burst_info {
>> uint8_t call_id;
>> uint8_t length;
>> char digits[0];
>> } __attribute__((__packed__));
>>
>> and set it up as follows
>> struct qmi_dtmf_burst_info *di;
>> di = alloca(2 + strlen(dtmf));
>> di->call_id = 0xff;
>> di->length = strlen(dtmf);
>> l_strlcpy(di->digits, dtmf, strlen(dtmf));
>> param = qmi_param_new();
>> if (!qmi_param_append(param, QMI_VOICE_DTMF_DATA, di->length + 2,
>> di))
>> goto error;
>> if (qmi_service_send(vd->voice, QMI_VOICE_BURST_DTMF, param,
>> send_dtmf_cb, cbd, l_free) > 0)
>> return;
Looks reasonable.
>> But, in the callback, in a call to qmi_result_set_error, i get back error
>> 24, which is QMI_PROTOCOL_ERROR_NETWORK_UNSUPPORTED right?
>> > Some further research suggested burst dtmf is only supported on 3gpp2
> (cdma2000?) .. so maybe the original implementation is more suitable.
>
Yeah, ERROR_NETWORK_UNSUPPORTED would seem to support this conclusion. I think
your v4 version was pretty close to being ready to be upstreamed.
Regards,
-Denis
next prev parent reply other threads:[~2024-04-25 20:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-21 19:49 [PATCH 1/4] qmimodem: voicecall: Implement call dialing Adam Pigg
2024-04-21 19:49 ` [PATCH 2/4] qmimodem: voicecall: Implement call answer Adam Pigg
2024-04-21 19:49 ` [PATCH 3/4] qmimodem: voicecall: Implement active call hangup Adam Pigg
2024-04-21 19:49 ` [PATCH 4/4] qmimodem: voicecall: Implement DTMF tones Adam Pigg
2024-04-21 20:06 ` Adam Pigg
2024-04-22 21:00 ` Denis Kenzior
2024-04-23 10:10 ` Adam Pigg
2024-04-23 15:01 ` Denis Kenzior
2024-04-23 21:54 ` Adam Pigg
2024-04-25 19:07 ` adam
2024-04-25 20:30 ` Denis Kenzior [this message]
2024-04-21 20:06 ` [PATCH 1/4] qmimodem: voicecall: Implement call dialing Adam Pigg
2024-04-22 21:05 ` Denis Kenzior
2024-04-22 21:10 ` patchwork-bot+ofono
-- strict thread matches above, loose matches on Subject: below --
2024-03-25 22:16 [PATCH 1/4] [qmimodem][voicecall] " Adam Pigg
2024-03-25 22:17 ` [PATCH 4/4] [qmimodem][voicecall] Implement DTMF tones Adam Pigg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a55c6dc-597f-4601-b9cc-3962c47dcca9@gmail.com \
--to=denkenz@gmail.com \
--cc=adam@piggz.co.uk \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).