From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/4] SARA R4 QMI support
Date: Mon, 22 Feb 2021 10:12:24 -0600 [thread overview]
Message-ID: <768c5ff2-d93d-97d3-d5e8-a1cbfe29e089@gmail.com> (raw)
In-Reply-To: <20210222101449.2809-2-jupiter.hce@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2703 bytes --]
Hi Jupiter,
On 2/22/21 4:14 AM, Jupiter wrote:
> From: jupiter <jupiter.hce@gmail.com>
Please provide a complete and properly capitalized real name with your
submission, otherwise I can't apply it.
>
> ---
> plugins/udevng.c | 41 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/plugins/udevng.c b/plugins/udevng.c
> index 34ac1cc0..63d95055 100644
> --- a/plugins/udevng.c
> +++ b/plugins/udevng.c
> @@ -1194,6 +1194,45 @@ static gboolean setup_ublox(struct modem_info *modem)
> return TRUE;
> }
>
> +static gboolean setup_ubloxqmi(struct modem_info *modem) {
> + const char *qmi = NULL, *net = NULL, *gps = NULL, *aux = NULL;
> + GSList *list;
> +
> + DBG("%s", modem->syspath);
> +
> + for (list = modem->devices; list; list = g_slist_next(list)) {
> + struct device_info *info = list->data;
> +
> + DBG("%s %s %s %s %s", info->devnode, info->interface,
> + info->number, info->label, info->subsystem);
> +
> + if (g_strcmp0(info->interface, "255/255/255") == 0 &&
> + g_strcmp0(info->number, "03") == 0) {
> + if (g_strcmp0(info->subsystem, "net") == 0)
> + net = info->devnode;
> + else if (g_strcmp0(info->subsystem, "usbmisc") == 0)
> + qmi = info->devnode;
> + }
> + }
> +
> + DBG("qmi=%s net=%s", qmi, net);
> +
> + if (qmi == NULL || net == NULL)
> + return FALSE;
> +
> + DBG("qmi=%s net=%s", qmi, net);
> +
> + ofono_modem_set_string(modem->modem, "Device", qmi);
> + ofono_modem_set_string(modem->modem, "NetworkInterface", net);
> + ofono_modem_set_string(modem->modem, "Quirk", "SARAR4");
you seem to be mixing tabs and spaces for indentation. Please fix that
> +
> + DBG("gps=%s aux=%s", gps, aux);
> +
> + ofono_modem_set_driver(modem->modem, "gobi");
> +
> + return TRUE;
> +}
> +
> static gboolean setup_gemalto(struct modem_info* modem)
> {
> const char *app = NULL, *gps = NULL, *mdm = NULL,
> @@ -1441,6 +1480,7 @@ static struct {
> { "quectel", setup_quectel },
> { "quectelqmi", setup_quectelqmi},
> { "ublox", setup_ublox },
> + { "ubloxqmi", setup_ubloxqmi },
Also here
> { "gemalto", setup_gemalto },
> { "xmm7xxx", setup_xmm7xxx },
> { "mbim", setup_mbim },
> @@ -1850,6 +1890,7 @@ static struct {
> { "ublox", "cdc_ncm", "1546", "110a" },
> { "ublox", "rndis_host", "1546", "1146" },
> { "ublox", "cdc_acm", "1546", "1146" },
> + { "ubloxqmi", "qmi_wwan", "05c6", "90b2" },
and here
> { "gemalto", "option", "1e2d", "0053" },
> { "gemalto", "cdc_wdm", "1e2d", "0053" },
> { "gemalto", "qmi_wwan", "1e2d", "0053" },
>
Regards,
-Denis
next prev parent reply other threads:[~2021-02-22 16:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 10:14 [PATCH 0/4] SARA R4 patches Jupiter
2021-02-22 10:14 ` [PATCH 1/4] SARA R4 QMI support Jupiter
2021-02-22 16:12 ` Denis Kenzior [this message]
2021-02-22 10:14 ` [PATCH 2/4] Add SARA R4 vendor ID Jupiter
2021-02-22 10:14 ` [PATCH 3/4] Check SARA R4 vendor ID, need to make it conditional on the actions being attach and detach Jupiter
2021-02-22 10:14 ` [PATCH 4/4] Add SARA R4 vendor and enable vendor in gprs create Jupiter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=768c5ff2-d93d-97d3-d5e8-a1cbfe29e089@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).