From: Denis Kenzior <denkenz@gmail.com>
To: ofono@lists.linux.dev
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH 1/2] gobi: Use LOW_POWER instead of PERSIST_LOW_POWER
Date: Tue, 30 Apr 2024 12:37:34 -0500 [thread overview]
Message-ID: <20240430173817.3044-1-denkenz@gmail.com> (raw)
PERSIST_LOW_POWER setting is supposed to tell the device that it should
not enter online state at the next bootup. Unfortunately, no USB
devices tested seem to honor this setting.
Telit devices in particular will turn off the SIM and become unusable
until set back into online mode. Use low-power instead of persistent
low power state instead. AlwaysOnline support is now no longer needed.
---
plugins/gobi.c | 4 ++--
plugins/udevng.c | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/plugins/gobi.c b/plugins/gobi.c
index 550ce78733f5..39c1ab81fa56 100644
--- a/plugins/gobi.c
+++ b/plugins/gobi.c
@@ -226,7 +226,7 @@ static void get_oper_mode_cb(struct qmi_result *result, void *user_data)
switch (data->oper_mode) {
case QMI_DMS_OPER_MODE_ONLINE:
param = qmi_param_new_uint8(QMI_DMS_PARAM_OPER_MODE,
- QMI_DMS_OPER_MODE_PERSIST_LOW_POWER);
+ QMI_DMS_OPER_MODE_LOW_POWER);
if (!param) {
shutdown_device(modem);
return;
@@ -480,7 +480,7 @@ static int gobi_disable(struct ofono_modem *modem)
goto out;
param = qmi_param_new_uint8(QMI_DMS_PARAM_OPER_MODE,
- QMI_DMS_OPER_MODE_PERSIST_LOW_POWER);
+ QMI_DMS_OPER_MODE_LOW_POWER);
if (!param)
return -ENOMEM;
diff --git a/plugins/udevng.c b/plugins/udevng.c
index b9d115f16b7d..243dcd6e91ec 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -850,7 +850,6 @@ static gboolean setup_telitqmi(struct modem_info *modem)
return FALSE;
ofono_modem_set_boolean(modem->modem, "ForceSimLegacy", TRUE);
- ofono_modem_set_boolean(modem->modem, "AlwaysOnline", TRUE);
return TRUE;
}
--
2.44.0
next reply other threads:[~2024-04-30 17:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 17:37 Denis Kenzior [this message]
2024-04-30 17:37 ` [PATCH 2/2] udevng: Add support for Telit FN990 Denis Kenzior
2024-05-01 21:00 ` [PATCH 1/2] gobi: Use LOW_POWER instead of PERSIST_LOW_POWER patchwork-bot+ofono
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430173817.3044-1-denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).