From: Denis Kenzior <denkenz@gmail.com>
To: ofono@lists.linux.dev
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH] qmi: gprs-context: Actually send param to qmi_service_send
Date: Thu, 25 Apr 2024 15:11:14 -0500 [thread overview]
Message-ID: <20240425201129.538276-1-denkenz@gmail.com> (raw)
The parameter structure was built, but not included into the
qmi_service_send call resulting in a memory leak.
Fixes: b6ced6c5c4c9 ("qmi: gprs-context: Request certain TLVs to be included")
---
drivers/qmimodem/gprs-context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/qmimodem/gprs-context.c b/drivers/qmimodem/gprs-context.c
index 055378dc102f..4004876bab87 100644
--- a/drivers/qmimodem/gprs-context.c
+++ b/drivers/qmimodem/gprs-context.c
@@ -194,7 +194,7 @@ static void start_net_cb(struct qmi_result *result, void *user_data)
param = qmi_param_new_uint32(PARAM_REQUESTED_SETTINGS,
requested_settings);
- if (qmi_service_send(data->wds, QMI_WDS_GET_CURRENT_SETTINGS, NULL,
+ if (qmi_service_send(data->wds, QMI_WDS_GET_CURRENT_SETTINGS, param,
get_settings_cb, cbd, cb_data_unref) > 0) {
cb_data_ref(cbd);
return;
--
2.44.0
next reply other threads:[~2024-04-25 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 20:11 Denis Kenzior [this message]
2024-04-25 20:20 ` [PATCH] qmi: gprs-context: Actually send param to qmi_service_send patchwork-bot+ofono
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425201129.538276-1-denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).