From: Denis Kenzior <denkenz@gmail.com>
To: ofono@lists.linux.dev
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH 1/3] voicecall: Fix memory leak
Date: Tue, 27 Feb 2024 09:33:02 -0600 [thread overview]
Message-ID: <20240227153314.1469536-1-denkenz@gmail.com> (raw)
'number' is obtained using g_key_file_get_string (which returns a newly
allocated string), but is never freed.
---
src/voicecall.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/voicecall.c b/src/voicecall.c
index d10fe15a423d..f979c46fe132 100644
--- a/src/voicecall.c
+++ b/src/voicecall.c
@@ -3462,7 +3462,7 @@ static void emulator_dial_callback(const struct ofono_error *error, void *data)
struct ofono_voicecall *vc = data;
gboolean need_to_emit;
struct voicecall *v;
- const char *number;
+ char *number;
GError *err = NULL;
number = g_key_file_get_string(vc->settings, SETTINGS_GROUP,
@@ -3484,6 +3484,8 @@ static void emulator_dial_callback(const struct ofono_error *error, void *data)
if (need_to_emit)
voicecalls_emit_call_added(vc, v);
+
+ g_free(number);
}
static void emulator_dial(struct ofono_emulator *em, struct ofono_voicecall *vc,
@@ -3585,7 +3587,7 @@ static void emulator_bldn_cb(struct ofono_emulator *em,
struct ofono_emulator_request *req, void *userdata)
{
struct ofono_voicecall *vc = userdata;
- const char *number;
+ char *number = NULL;
struct ofono_error result;
GError *error = NULL;
@@ -3608,6 +3610,8 @@ fail:
result.type = OFONO_ERROR_TYPE_FAILURE;
ofono_emulator_send_final(em, &result);
};
+
+ g_free(number);
}
static void emulator_hfp_watch(struct ofono_atom *atom,
--
2.43.0
next reply other threads:[~2024-02-27 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 15:33 Denis Kenzior [this message]
2024-02-27 15:33 ` [PATCH 2/3] voicecall: Fix use after free Denis Kenzior
2024-02-27 15:33 ` [PATCH 3/3] lte: Fix invalid cleanup Denis Kenzior
2024-02-27 17:50 ` [PATCH 1/3] voicecall: Fix memory leak patchwork-bot+ofono
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227153314.1469536-1-denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).