From: Steve Schrock <steve.schrock@getcruise.com>
To: ofono@lists.linux.dev
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH] qmi: Make sure to set transaction id as LE16
Date: Tue, 27 Feb 2024 03:25:52 +0000 [thread overview]
Message-ID: <20240227032552.123044-1-steve.schrock@getcruise.com> (raw)
From: Denis Kenzior <denkenz@gmail.com>
Transaction identifier for QMI service messages was always read in as
LE16 value, however when allocating a request it was set in host byte
order. Fix that.
---
drivers/qmimodem/qmi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/qmimodem/qmi.c b/drivers/qmimodem/qmi.c
index 2371f178..35751d7c 100644
--- a/drivers/qmimodem/qmi.c
+++ b/drivers/qmimodem/qmi.c
@@ -670,13 +670,13 @@ static uint16_t __request_submit(struct qmi_device *device,
struct qmi_service_hdr *hdr =
(struct qmi_service_hdr *) &req->data[QMI_MUX_HDR_SIZE];
- hdr->type = 0x00;
- hdr->transaction = device->next_service_tid++;
+ req->tid = device->next_service_tid++;
if (device->next_service_tid < 256)
device->next_service_tid = 256;
- req->tid = hdr->transaction;
+ hdr->type = 0x00;
+ hdr->transaction = L_CPU_TO_LE16(req->tid);
l_queue_push_tail(device->req_queue, req);
wakeup_writer(device);
--
2.40.1
--
*Confidentiality Note:* We care about protecting our proprietary
information, confidential material, and trade secrets. This message may
contain some or all of those things. Cruise will suffer material harm if
anyone other than the intended recipient disseminates or takes any action
based on this message. If you have received this message (including any
attachments) in error, please delete it immediately and notify the sender
promptly.
reply other threads:[~2024-02-27 3:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227032552.123044-1-steve.schrock@getcruise.com \
--to=steve.schrock@getcruise.com \
--cc=denkenz@gmail.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).