From: Steve Schrock <steve.schrock@getcruise.com>
To: ofono@lists.linux.dev
Cc: Steve Schrock <steve.schrock@getcruise.com>
Subject: [PATCH 7/7] qmimodem: Use l_free in qmi_free for consistency
Date: Wed, 21 Feb 2024 21:22:12 +0000 [thread overview]
Message-ID: <20240221212212.181401-7-steve.schrock@getcruise.com> (raw)
In-Reply-To: <20240221212212.181401-1-steve.schrock@getcruise.com>
Eliminate the final gchar* as well.
---
drivers/qmimodem/qmi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/qmimodem/qmi.c b/drivers/qmimodem/qmi.c
index ba6ae0d2..52a8e57c 100644
--- a/drivers/qmimodem/qmi.c
+++ b/drivers/qmimodem/qmi.c
@@ -174,7 +174,7 @@ struct qmi_tlv_hdr {
void qmi_free(void *ptr)
{
- free(ptr);
+ l_free(ptr);
}
static struct qmi_request *__request_alloc(uint8_t service,
@@ -1424,7 +1424,7 @@ static char *get_device_interface(struct qmi_device *device)
file_name = basename(file_path);
for (i = 0; i < L_ARRAY_SIZE(driver_names) && !interface; i++) {
- gchar *sysfs_path;
+ char *sysfs_path;
sysfs_path = l_strdup_printf("/sys/class/%s/%s/device/net/",
driver_names[i], file_name);
@@ -1813,7 +1813,7 @@ char *qmi_result_get_string(struct qmi_result *result, uint8_t type)
if (!ptr)
return NULL;
- return strndup(ptr, len);
+ return l_strndup(ptr, len);
}
bool qmi_result_get_uint8(struct qmi_result *result, uint8_t type,
--
2.40.1
--
*Confidentiality Note:* We care about protecting our proprietary
information, confidential material, and trade secrets. This message may
contain some or all of those things. Cruise will suffer material harm if
anyone other than the intended recipient disseminates or takes any action
based on this message. If you have received this message (including any
attachments) in error, please delete it immediately and notify the sender
promptly.
prev parent reply other threads:[~2024-02-21 21:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 21:22 [PATCH 1/7] qmimodem: Use l_queue_remove_if to eliminate double lookup Steve Schrock
2024-02-21 21:22 ` [PATCH 2/7] qmimodem: Use l_timeout for discovery Steve Schrock
2024-02-21 21:22 ` [PATCH 3/7] qmimodem: Use l_idle for shutdown instead of g_timeout Steve Schrock
2024-02-21 21:22 ` [PATCH 4/7] qmimodem: Use l_idle and l_timeout for service creation Steve Schrock
2024-02-21 21:22 ` [PATCH 5/7] qmimodem: Use l_idle for discovery when timeout is 0 Steve Schrock
2024-02-21 21:22 ` [PATCH 6/7] qmimodem: Eliminate glib macros Steve Schrock
2024-02-21 21:22 ` Steve Schrock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240221212212.181401-7-steve.schrock@getcruise.com \
--to=steve.schrock@getcruise.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).