From: Slava Monich <slava.monich@jolla.com>
To: ofono@ofono.org
Subject: [PATCH 1/2] sim-auth: Remove watch if open_channel fails
Date: Mon, 26 Apr 2021 11:17:33 +0300 [thread overview]
Message-ID: <20210426081734.2460416-1-slava.monich@jolla.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
Otherwise open_channel won't be called again after a failure.
---
src/sim-auth.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/sim-auth.c b/src/sim-auth.c
index 0e13b533..3c3f35e7 100644
--- a/src/sim-auth.c
+++ b/src/sim-auth.c
@@ -367,6 +367,8 @@ static void get_session_cb(ofono_bool_t active, int session_id,
error:
__ofono_dbus_pending_reply(&sa->pending->msg,
__ofono_error_failed(sa->pending->msg));
+ __ofono_sim_remove_session_watch(sa->pending->session,
+ sa->pending->watch_id);
g_free(sa->pending);
sa->pending = NULL;
}
--
2.25.1
next reply other threads:[~2021-04-26 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 8:17 Slava Monich [this message]
2021-04-26 8:17 ` [PATCH 2/2] sim-auth: Only close open sessions Slava Monich
2021-04-30 14:31 ` [PATCH 1/2] sim-auth: Remove watch if open_channel fails Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210426081734.2460416-1-slava.monich@jolla.com \
--to=slava.monich@jolla.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).