From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v1 5/5] Use tabs as Denis required
Date: Tue, 23 Feb 2021 14:08:20 -0600 [thread overview]
Message-ID: <08ea8330-e97c-2326-5c91-806f26d98958@gmail.com> (raw)
In-Reply-To: <20210223044653.4933-6-jupiter.hce@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
Hi Jupiter,
On 2/22/21 10:46 PM, Bing Jupiter wrote:
> From: Jupiter <jupiter.hce@gmail.com>
Please make sure your authorship information is updated in the commit meta-data
as well for all the patches you're submitting.
>
> ---
> drivers/atmodem/vendor.h | 2 +-
> drivers/qmimodem/gprs.c | 26 +++++++++++++-------------
> plugins/gobi.c | 14 +++++++-------
> plugins/udevng.c | 6 +++---
> 4 files changed, 24 insertions(+), 24 deletions(-)
>
No, please don't do it this way. This patch should not exist. Instead take
the changes from this patch and amend the previous 4 patches. In other words,
the previous 4 patches should be following the coding style as documented in
doc/coding-style.txt.
Regards,
-Denis
prev parent reply other threads:[~2021-02-23 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 4:46 [PATCH v1 0/5] oFono uBlox SARA R4 QMI support Bing Jupiter
2021-02-23 4:46 ` [PATCH v1 1/5] Change 1: " Bing Jupiter
2021-02-23 4:46 ` [PATCH v1 2/5] Change 2: Add SARA R4 vendor ID Bing Jupiter
2021-02-23 4:46 ` [PATCH v1 3/5] Change 3: Check SARA R4 vendor ID, need to make it conditional on the actions being attach and detach Bing Jupiter
2021-02-23 4:46 ` [PATCH v1 4/5] Change 4: Add SARA R4 vendor and enable vendor in gprs create Bing Jupiter
2021-02-23 4:46 ` [PATCH v1 5/5] Use tabs as Denis required Bing Jupiter
2021-02-23 20:08 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08ea8330-e97c-2326-5c91-806f26d98958@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).