From: "Leizhen (ThunderTown)" <thunder.leizhen@huaweicloud.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel test robot <oliver.sang@intel.com>
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [linus:master] [kobject] 1b28cb81da: canonical_address#:#[##]
Date: Sun, 18 Feb 2024 10:01:00 +0800 [thread overview]
Message-ID: <ab5434ce-23b3-1e99-1bb0-0ac7cf9996f0@huaweicloud.com> (raw)
In-Reply-To: <2024020840-bladder-service-0341@gregkh>
On 2024/2/8 23:48, Greg Kroah-Hartman wrote:
> On Wed, Feb 07, 2024 at 02:42:43PM +0800, kernel test robot wrote:
>>
>>
>> Hello,
>>
>> kernel test robot noticed "canonical_address#:#[##]" on:
>>
>> commit: 1b28cb81dab7c1eedc6034206f4e8d644046ad31 ("kobject: Remove redundant checks for whether ktype is NULL")
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>>
>> [test failed on linus/master 54be6c6c5ae8e0d93a6c4641cb7528eb0b6ba478 (v6.8-rc3)]
>> [test failed on linux-next/master 076d56d74f17e625b3d63cf4743b3d7d02180379]
>>
>> in testcase: boot
>>
>> compiler: gcc-11
>> test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G
>>
>> (please refer to attached dmesg/kmsg for entire log/backtrace)
>>
>>
>>
>> we noticed this issue is very random, as below, observed 4 times out of 68 runs.
>> but we didn't see in on parent.
>
> Ok, this is odd, but a good enough reason to revert this for now. I was
> worried about it, and this confirms my worry that there's some codepath
> we aren't taking into account here that those checks were protecting us
> from doing bad things.
Yes, there may be some non-standard usage. kobj->ktype was detached first?
>
> thanks for the report, and Zhen, if you want to dig into this and see if
> you can figure out what is happening so that you can submit your change
> again, that would be great.
I'm trying to reproduce it. However, for me, it may take a lot of time to
prepare the environment. If kobj->name was printed when the error is
detected, we may be able to solve it directly by reviewing the code.
>
> greg k-h
> .
>
--
Regards,
Zhen Lei
prev parent reply other threads:[~2024-02-18 2:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 6:42 [linus:master] [kobject] 1b28cb81da: canonical_address#:#[##] kernel test robot
2024-02-08 15:48 ` Greg Kroah-Hartman
2024-02-18 2:01 ` Leizhen (ThunderTown) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab5434ce-23b3-1e99-1bb0-0ac7cf9996f0@huaweicloud.com \
--to=thunder.leizhen@huaweicloud.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).