From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: linux-nfc@lists.01.org
Subject: Re: [PATCH] nfc: nfcmrvl: spi: Fix irq_of_parse_and_map() return value
Date: Sat, 23 Apr 2022 11:28:35 +0200 [thread overview]
Message-ID: <e7eb0c05-7056-7aeb-ebca-399f11d22122@linaro.org> (raw)
In-Reply-To: <20220422161305.59e0be38@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
On 23/04/2022 01:13, Jakub Kicinski wrote:
> On Fri, 22 Apr 2022 12:47:58 +0200 Krzysztof Kozlowski wrote:
>> The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO.
>>
>> Fixes: caf6e49bf6d0 ("NFC: nfcmrvl: add spi driver")
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> This is another issue to https://lore.kernel.org/all/20220422084605.2775542-1-lv.ruyi(a)zte.com.cn/
>
> Maybe send one patch that fixes both and also fixes the usage of ret?
Bah, I just blindly copied one part of his patch without deeper check.
Thanks for noticing it.
Best regards,
Krzysztof
next parent reply other threads:[~2022-04-23 9:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220422161305.59e0be38@kernel.org>
2022-04-23 9:28 ` Krzysztof Kozlowski [this message]
2022-04-22 10:47 [PATCH] nfc: nfcmrvl: spi: Fix irq_of_parse_and_map() return value Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7eb0c05-7056-7aeb-ebca-399f11d22122@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=linux-nfc@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).