From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: linux-nfc@lists.01.org
Subject: [neard][PATCH 7/7] unit: fix records GList memory leak in test-snep-read
Date: Fri, 16 Jul 2021 12:08:44 +0200 [thread overview]
Message-ID: <20210716100844.51360-8-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210716100844.51360-1-krzysztof.kozlowski@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 1858 bytes --]
The test_snep_dummy_req_put() stores one record in global stored_recd
pointer, so the GList itself should be freed. This fixes Valgrind
warning:
24 bytes in 1 blocks are definitely lost in loss record 21 of 30
at 0x483C7F3: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x48CA698: g_malloc (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.6600.1)
by 0x48E2CF1: g_slice_alloc (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.6600.1)
by 0x48BFF07: g_list_append (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.6600.1)
by 0x11E68A: near_ndef_parse_msg (ndef.c:2964)
by 0x122A23: test_snep_dummy_req_put (test-snep-read.c:131)
by 0x122005: snep_core_process_request (snep.c:397)
by 0x122005: near_snep_core_read (snep.c:617)
by 0x123042: test_snep_read_req_common.constprop.0 (test-snep-read.c:352)
by 0x1234E0: test_snep_read_put_req_ok (test-snep-read.c:500)
by 0x1234E0: test_snep_read_get_req_ok (test-snep-read.c:644)
by 0x48ECDCD: ??? (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.6600.1)
by 0x48ECBCA: ??? (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.6600.1)
by 0x48ED2B9: g_test_run_suite (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.6600.1)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
unit/test-snep-read.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/unit/test-snep-read.c b/unit/test-snep-read.c
index a4df6ec95f8f..2e977f749610 100644
--- a/unit/test-snep-read.c
+++ b/unit/test-snep-read.c
@@ -142,6 +142,7 @@ static bool test_snep_dummy_req_put(int fd, void *data)
g_free(nfc_data);
stored_recd = records->data;
+ g_list_free(records);
TEST_SNEP_LOG("\t\tdummy_req_put STORED REC data=%p length=%zu\n",
stored_recd->data, stored_recd->data_len);
--
2.27.0
prev parent reply other threads:[~2021-07-16 10:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 10:08 [neard][PATCH 0/7] Fixes for more memory issues Krzysztof Kozlowski
2021-07-16 10:08 ` [neard][PATCH 1/7] snep: do not open-code freeing ndef message Krzysztof Kozlowski
2021-07-16 10:08 ` [neard][PATCH 2/7] unit: fix memory leaks in test-ndef-build Krzysztof Kozlowski
2021-07-16 10:08 ` [neard][PATCH 3/7] snep: remove useless NULL-ify of local pointer variable Krzysztof Kozlowski
2021-07-16 10:08 ` [neard][PATCH 4/7] snep: fix double free of GSList Krzysztof Kozlowski
2021-07-16 10:08 ` [neard][PATCH 5/7] unit: fix memory leaks in test-snep-read error paths Krzysztof Kozlowski
2021-07-16 10:08 ` [neard][PATCH 6/7] unit: fix record memory leak in test-snep-read Krzysztof Kozlowski
2021-07-16 10:08 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210716100844.51360-8-krzysztof.kozlowski@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=linux-nfc@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).